Skip to content

Conversation

sundberg84
Copy link

Correct MY_WITH_LEDS_BLINKING_INVERSE (Include now means leds are always lit)

Correct MY_WITH_LEDS_BLINKING_INVERSE (Include now means leds are always lit)
@mysensors-jenkins
Copy link

As the author of this pull request is not in my whitelist, I may not build this PR automatically.
A member of the MySensors core team can ask me to verify this pull request by telling me "jenkins, build this please".
The author can be whitelisted to get future PR:s automatically verified by telling me "jenkins, add author to whitelist please".
But remember that I will only listen if you name me with a capital 'J'.
If you would like to submit a PR and not have Jenkins build it for you, you can add "[skip ci]" to your PR "body".

@fallberg
Copy link
Contributor

fallberg commented Jan 7, 2016

Please be more descriptive in the commit headline. The headline gives no information on what you actually changed.

@sundberg84 sundberg84 changed the title Update MyLeds.h MY_WITH_LEDS_BLINKING_INVERSE now turns led always on and blinks off. Jan 7, 2016
@sundberg84
Copy link
Author

Sorry, first request... also didnt sign any agreement but whatever that is i agree to that.

@fallberg
Copy link
Contributor

fallberg commented Jan 7, 2016

Jenkins, build this please

@fallberg
Copy link
Contributor

fallberg commented Jan 7, 2016

Actually, your commit headline remains unchanged. Please remember to format your commit message a bit better next time :)
Here is a good guide: http://chris.beams.io/posts/git-commit/

@sundberg84
Copy link
Author

It changed here in the header on the pull request but not in the build :/
Yes, will read - thank you for the link.

@sundberg84 sundberg84 changed the title MY_WITH_LEDS_BLINKING_INVERSE now turns led always on and blinks off. Fix MY_WITH_LEDS_BLINKING_INVERSE always on/blink off Jan 7, 2016
@mysensors-jenkins
Copy link

Congratulations! I found no problems building this pull request for any of the supported boards or examples.
You can see the result of the build(s) here: http://ci.mysensors.org/job/MySensorsArduinoPR/314/

@fallberg
Copy link
Contributor

fallberg commented Jan 7, 2016

You can't change a commit message without amending the commit and pushing the updated commit. The pr header is the label the merge commit will get but tour own commit will also show in the git history, hence the need for well written commit messages so the history makes sense.

@fallberg
Copy link
Contributor

fallberg commented Jan 7, 2016

Regarding the actual change, isn't this depending on how the led is connected? What is the default for MySensors? To sink the led or source it? @henrikekblad do you know?

@sundberg84
Copy link
Author

I have it connected 7,8,9 to Gnd on a Uno with Ethernet Shield if you need that info.

@fallberg
Copy link
Contributor

fallberg commented Jan 7, 2016

Ok, because the official building instructions have them connected to VCC and the pin sinks the net. So the default behaviour is correct with those instructions.

@sundberg84
Copy link
Author

Oh, sorry - my misstake then... :( I must have missed that...
Then we can just close/remove this pull I guess.

@sundberg84 sundberg84 closed this Jan 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants