-
-
Notifications
You must be signed in to change notification settings - Fork 895
Fix MY_WITH_LEDS_BLINKING_INVERSE always on/blink off #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Correct MY_WITH_LEDS_BLINKING_INVERSE (Include now means leds are always lit)
As the author of this pull request is not in my whitelist, I may not build this PR automatically. |
Please be more descriptive in the commit headline. The headline gives no information on what you actually changed. |
Sorry, first request... also didnt sign any agreement but whatever that is i agree to that. |
Jenkins, build this please |
Actually, your commit headline remains unchanged. Please remember to format your commit message a bit better next time :) |
It changed here in the header on the pull request but not in the build :/ |
Congratulations! I found no problems building this pull request for any of the supported boards or examples. |
You can't change a commit message without amending the commit and pushing the updated commit. The pr header is the label the merge commit will get but tour own commit will also show in the git history, hence the need for well written commit messages so the history makes sense. |
Regarding the actual change, isn't this depending on how the led is connected? What is the default for MySensors? To sink the led or source it? @henrikekblad do you know? |
I have it connected 7,8,9 to Gnd on a Uno with Ethernet Shield if you need that info. |
Ok, because the official building instructions have them connected to VCC and the pin sinks the net. So the default behaviour is correct with those instructions. |
Oh, sorry - my misstake then... :( I must have missed that... |
Correct MY_WITH_LEDS_BLINKING_INVERSE (Include now means leds are always lit)