Skip to content

Conversation

mfalkvidd
Copy link
Member

The examples used hard-coded values or defines to convert digital
pin number to interrupt in calls to attachInterrupt and sleep.

This has confused several people, most recently in
https://forum.mysensors.org/topic/3880/gw-sleep-on-battery-powered-magnet-door-switch/

Let digitalPinToInterrupt handle this work instead.

I agree to CLA.

The examples used hard-coded values or defines to convert digital
pin number to interrupt in calls to attachInterrupt and sleep.

This has confused several people, most recently in
https://forum.mysensors.org/topic/3880/gw-sleep-on-battery-powered-magnet-door-switch/

Let digitalPinToInterrupt handle this work instead.
@fallberg
Copy link
Contributor

Jenkins, build this please?

@fallberg
Copy link
Contributor

Apparently, a recent upgrade on Jenkins have caused the PR verifier to fail. I apologize for the inconvenience and work on a solution.

@mfalkvidd
Copy link
Member Author

No worries @fallberg

@mysensors-jenkins
Copy link

This is Jenkins trying to connect....

@fallberg
Copy link
Contributor

Jenkins, build this please

@fallberg
Copy link
Contributor

Jenkins, I just downgraded your pull requester plugin. Now, Jenkins, build this please, or I'll kick your ass for real!

@fallberg
Copy link
Contributor

Jenkins, build this please. Pleeease...

@fallberg
Copy link
Contributor

For some reason, the plugin no longer injects the environment variables it is supposed to. Not sure what to make of that as of now. Jenkins, build this please.

@fallberg
Copy link
Contributor

Jenkins, build examples please

@fallberg
Copy link
Contributor

I blame the plugin for this so I created a issue and hope they resolve it: jenkinsci/ghprb-plugin#342

@tekka007 tekka007 added this to the 2.0.0 milestone May 17, 2016
@fallberg
Copy link
Contributor

Shit's about to get real! Jenkins, build this please.

@mysensors-jenkins
Copy link

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

@mysensors-jenkins
Copy link

Congratulations! I found no problems building this pull request for any of the supported boards or examples.
You can see the result of the build(s) here: http://ci.mysensors.org/job/MySensorsArduinoPR/444/

@henrikekblad
Copy link
Member

Jenkins, build examples please.

@mysensors-jenkins
Copy link

Congratulations! I found no problems building this pull request for any of the supported boards or examples.
You can see the result of the build(s) here: http://ci.mysensors.org/job/MySensorsArduinoPR/446/

@henrikekblad henrikekblad merged commit 021412f into mysensors:development May 19, 2016
@JohanElmis
Copy link

Dear,

That stuff I just found on the web is admirable, you have to take a look http://booklet.iparcelplus.com/e4mvxoy

Sincerely yours, johan

@JohanElmis
Copy link

Hello,

I'm so excited to tell you about yesterday that was full of pleasant surprises, just take a look at that http://ndagustiko.dynamohomes.com/e4bcpdpi

Best, johan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants