smartSleep: send heartbeat before sleeping

[abmantis]

Sending the heartbeat (and waiting) after waking up would delay processing inputs. For example, a switch could be back to the open state before the wait is over.

[mysensors-jenkins]

Git commit message(s) not good enough. I have mailed the details to the PR author.

[mysensors-jenkins]

Git commit message(s) look good!

[mysensors-jenkins]

I found warnings (compiler or Doxygen related) in the MySensors core library when building the core library verification sketches. Please rebuild your changes locally with all warnings enabled in the Arduino IDE and make sure it compiles cleanly and resubmit your changes. You do not need to resolve warnings that are unrelated to your change.
You can see the result of the build(s) here: http://ci.mysensors.org/job/MySensorsArduinoLibPR/191/
Compiler warnings exist in the Subproject Builds marked with yellow. Click the yellow dot and then on "Arduino/AVR warnings" to review the warnings reported.
Doxygen warnings are reported here: http://ci.mysensors.org/job/MySensorsArduinoLibPR/191/warnings14Result
A member of the MySensors core team can retrigger a build on this exact commit by telling me "jenkins, build this please".
But remember that I will only listen if you name me with a capital 'J'.
If the PR is updated I will rebuild it automatically.

[mysensors-jenkins]

I found warnings (compiler or Doxygen related) in the MySensors core library when building the core library verification sketches. Please rebuild your changes locally with all warnings enabled in the Arduino IDE and make sure it compiles cleanly and resubmit your changes. You do not need to resolve warnings that are unrelated to your change.
You can see the result of the build(s) here: http://ci.mysensors.org/job/MySensorsArduinoLibPR/192/
Compiler warnings exist in the Subproject Builds marked with yellow. Click the yellow dot and then on "Arduino/AVR warnings" to review the warnings reported.
Doxygen warnings are reported here: http://ci.mysensors.org/job/MySensorsArduinoLibPR/192/warnings14Result
A member of the MySensors core team can retrigger a build on this exact commit by telling me "jenkins, build this please".
But remember that I will only listen if you name me with a capital 'J'.
If the PR is updated I will rebuild it automatically.

[fallberg]

Warnings are unrelated to this pr and can be ignored. There is another open pr that resolves the warnings.

[tekka007]

Jenkins, build this please

[mysensors-jenkins]

I found warnings (compiler or Doxygen related) in the MySensors core library when building the core library verification sketches. Please rebuild your changes locally with all warnings enabled in the Arduino IDE and make sure it compiles cleanly and resubmit your changes. You do not need to resolve warnings that are unrelated to your change.
You can see the result of the build(s) here: http://ci.mysensors.org/job/MySensorsArduinoLibPR/206/
Compiler warnings exist in the Subproject Builds marked with yellow. Click the yellow dot and then on "Arduino/AVR warnings" to review the warnings reported.
Doxygen warnings are reported here: http://ci.mysensors.org/job/MySensorsArduinoLibPR/206/warnings14Result
A member of the MySensors core team can retrigger a build on this exact commit by telling me "jenkins, build this please".
But remember that I will only listen if you name me with a capital 'J'.
If the PR is updated I will rebuild it automatically.

[tekka007]

@abmantis Please rebase this PR to the most recent dev branch to resolve the warnings

[mysensors-jenkins]

Git commit message(s) look good!

[mysensors-jenkins]

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

[tekka007]

Jenkins, build examples please

[mysensors-jenkins]

Congratulations! I found no problems building this pull request for any of the supported boards or examples.
You can see the result of the build(s) here: http://ci.mysensors.org/job/MySensorsArduinoPR/471/

[tbowmo]

There seems to be conflicts, probably due to some of the other PR's that has come in lately.

Do you mind doing another rebase against recent development?

[tekka007]

PR closed due to inactivity

[MartinHjelmare]

@tekka007 Will you fix the not working smartsleep before the release, or do you want a PR?

[tekka007]

Please feel free to submit an updated PR. Thanks
On Jul 7, 2016 12:09, "Martin Hjelmare" notifications@github.com wrote:

@tekka007 https://github.com/tekka007 Will you fix the not working
smartsleep before the release, or do you want a PR?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#465 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AH6swj_Z5kcRESv47HBkKtWfPkJKr4Hgks5qTNBdgaJpZM4IzayC
.

[MartinHjelmare]

I'm currently AFK so I can't do it until this Sunday at the earliest. I hope we can do a minor release with fixes if this won't make the big one.

[abmantis]

I may be able to update this today or tomorrow, but can't promise. When is the release?

[MartinHjelmare]

Sat 9 July, planned, I think.

[abmantis]

Ok, I'll try to update it before that.

[JohanElmis]

Hi friend!

Look what I've just found! Have you already seen that great stuff? Check it out http://matter.riddlesurfer.com/e4tbsi

Regards, johan

[JohanElmis]

Dear!

I wanted to share with you some interesting links that they gave us at the last meeting, here is the list http://success.954homeloans.com/e4xvpp

Typos courtesy of my iPhone, johan

[JohanElmis]

Dear friend!

I've read spmething worthy on the web and I think this is a very good idea for your business, take a look http://chahodofra.gailssnails.com/e4gsnrah

Sincerely yours, johan

[JohanElmis]

Hi!

I've read a nice and informative article about some stuff you may really like, you can find more info here http://thododene.officespaceguys.com/e4xlcxd

All best, johan