Kill Gitler and make way for The Butler #1124
Conversation
fallberg
force-pushed
the
butler
branch
28 times, most recently
from
d735979
to
e64c432
Compare
The Butler is a more polite and helpful replacement to the grumpy old Gitler. The Butler will do his utmost to assist new (and old) contributors to the MySensors cause.
| body: """<p>Job '${env.JOB_NAME} [<a href="${env.CHANGE_URL}">PR#${env.CHANGE_ID}</a> - ${env.CHANGE_TITLE}]' failed because code style does not follow the standards.</p> | ||
| A patch to rectify the errors is attached. You apply the patch using:<br> | ||
| subject: "PR#${env.CHANGE_ID} - ${env.CHANGE_TITLE} has unfortunate code styling", | ||
| body: """<p>Greetings Sir!<p> |
There was a problem hiding this comment.
This assumes the person submitting the PR is a man. Shouldn't we try to be as inclusive as possible?
There was a problem hiding this comment.
Omg what a Swedish comment 🤣
I think sir can be applied in general though. At least in the military, which is kind of The Butlers inheritance :)
There was a problem hiding this comment.
Would it hurt the text to remove the use of "Sir" by the butler?
There was a problem hiding this comment.
The butler uses Master in "Well done Master" which isn't very gender-neutral either. Would be nice to use the same word everywhere.
Maybe use "Highness" or "Your Grace"?
We want the butler to be perceived as helpful and polite (instead of harsh and demanding) so some sort of polite expression would be nice.
There was a problem hiding this comment.
Well, Well done Master is exclusive for core team members, and last time I checked, it was not very gender-neutral either.
If Sir is not good enough, please suggest alternatives. "Highness" and "Your Grace" sounds a bit odd and overly arcane I think.
There was a problem hiding this comment.
I would remove all titles altogether.
There was a problem hiding this comment.
Ok, lets go for that. I see the PR is already merged. Will you file a new one?
There was a problem hiding this comment.
Ok, I'll take a shot.
The Butler is a more polite and helpful replacement to the grumpy old Gitler. The Butler will do his utmost to assist new (and old) contributors to the MySensors cause.
The Butler is a more polite and helpful replacement to the grumpy old Gitler.
The Butler will do his utmost to assist new (and old) contributors to the MySensors cause.