-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump xapian-full-alaveteli from 1.2.21.1 to 1.4.11.1 #5720
Bump xapian-full-alaveteli from 1.2.21.1 to 1.4.11.1 #5720
Conversation
6bc3bbf
to
4bfbedc
Compare
4bfbedc
to
4be070e
Compare
@@ -833,7 +833,7 @@ def self.destroy_and_rebuild_index(model_classes, verbose = false, terms = true, | |||
if File.exist?(temp_path) | |||
if not ActsAsXapian._is_xapian_db(temp_path) | |||
@@db_path = old_path | |||
raise "old database now at " + temp_path + " is not Xapian flint database, please delete for me" | |||
raise "old database now at " + temp_path + " is not Xapian chert database, please delete for me" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [104/80]
@@ -821,7 +821,7 @@ def self.destroy_and_rebuild_index(model_classes, verbose = false, terms = true, | |||
temp_path = old_path + ".tmp" | |||
if File.exist?(temp_path) | |||
@@db_path = old_path | |||
raise "temporary database found " + temp_path + " which is not Xapian flint database, please delete for me" if not ActsAsXapian._is_xapian_db(temp_path) | |||
raise "temporary database found " + temp_path + " which is not Xapian chert database, please delete for me" if not ActsAsXapian._is_xapian_db(temp_path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Favor unless over if for negative conditions.
Line is too long. [158/80]
Use ! instead of not.
@@ -791,7 +791,7 @@ def self.destroy_and_rebuild_index(model_classes, verbose = false, terms = true, | |||
new_path = ActsAsXapian.db_path + ".new" | |||
old_path = ActsAsXapian.db_path | |||
if File.exist?(new_path) | |||
raise "found existing " + new_path + " which is not Xapian flint database, please delete for me" if not ActsAsXapian._is_xapian_db(new_path) | |||
raise "found existing " + new_path + " which is not Xapian chert database, please delete for me" if not ActsAsXapian._is_xapian_db(new_path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Favor unless over if for negative conditions.
Line is too long. [146/80]
Use ! instead of not.
@@ -258,7 +258,7 @@ def self.writable_init(suffix = "") | |||
full_path = @@db_path + suffix | |||
|
|||
# for indexing | |||
@@writable_db = Xapian::WritableDatabase.new(full_path, Xapian::DB_CREATE_OR_OPEN) | |||
@@writable_db = Xapian::WritableDatabase.new(full_path, Xapian::DB_CREATE_OR_OPEN | Xapian::DB_BACKEND_CHERT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace class var @@writable_db with a class instance var.
Line is too long. [113/80]
Bumps [xapian-full-alaveteli](https://github.com/mysociety/xapian-full) from 1.2.21.1 to 1.4.11.1. - [Release notes](https://github.com/mysociety/xapian-full/releases) - [Commits](https://github.com/mysociety/xapian-full/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
4be070e
to
f9c359f
Compare
Bumps xapian-full-alaveteli from 1.2.21.1 to 1.4.11.1.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and language@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: