Updates and Fixes for WikiBots #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We see errors from `wikibot-pipedrive` when run from cron due to the presence of unicode characters that don't match the default encoding for STDOUT, ASCII. Setting `PYTHONIOENCODING` ensures the encoding is set correctly.
With more recent versions of MediaWiki and the Auth_remoteuser plugin it seems this call to `site.login` generates an error which prevents access. This is unnecessary as the user is being identified by the HTTP authentication process.
sagepe
force-pushed
the
google-oauth-client-update
branch
from
df64568
to
b6c3d20
Compare
|
I've updated this PR to include some additional changes:
|
sagepe
changed the title
dracos
reviewed
Jan 22, 2019
| @@ -6,7 +6,7 @@ PATH=/usr/local/bin:/usr/bin:/bin | |||
| PYTHON=/data/vhost/!!(*= $vhost *)!!/virtualenv-wiki/bin/python | |||
|
|
|||
| 24 5 * * * !!(*= $user *)!! $PYTHON /data/vhost/!!(*= $vhost *)!!/internal/wiki/bin/wikibot-fixup.py | |||
| 36 3 * * * !!(*= $user *)!! $PYTHON /data/vhost/!!(*= $vhost *)!!/internal/wiki/bin/wikibot-pipedrive.py | |||
| 36 3 * * * !!(*= $user *)!! export PYTHONIOENCODING=utf-8; $PYTHON /data/vhost/!!(*= $vhost *)!!/internal/wiki/bin/wikibot-pipedrive.py | |||
There was a problem hiding this comment.
Better solution would be to use python3 instead ;-)
There was a problem hiding this comment.
Maybe I'll have a chat with @jacksonj04 about revisiting #40.
The `SignedJwtAssertionCredentials` class was deprecated and removed from `oauth2client` some considerable time ago. This change uses the replacement `ServiceAccountCredentials` construct.
Updated `requirements.txt` for the wiki that includes a newer version of the `oauth2client` package.
sagepe
force-pushed
the
google-oauth-client-update
branch
from
b6c3d20
to
de232b9
Compare
|
I'm going to merge this - this gets everything running then we can then work on the wider improvements in dedicated issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SignedJwtAssertionCredentialsclass was deprecated and removed fromoauth2clientsome considerable time ago. This change uses the replacement and also updates the virtual environment's requirements file to reflect this.See also sysadmin#858.