Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate register page #1797

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Separate register page #1797

merged 3 commits into from
Jun 5, 2024

Conversation

ajparsons
Copy link
Contributor

@ajparsons ajparsons commented Jun 2, 2024

Move register of interests to separate sub profile page.

  • Clearer top navigation from overview page (We should do the same to debates at some point)
  • Track interest in this feature
  • More room for text about whofundsthem.

Room for improving this with new boilerplate text - but this does a few things quickly.

As we want to do this with recent debates/future features(!?) i've moved the list of allowed sub-profile pages from httpd.conf into the profile php page to have more of the logic in one place. But we add new features rarely enough if the other approach is better for some reason can switch back.

image

- Move check from httpd.conf to mp/index.php
@ajparsons ajparsons requested a review from dracos June 2, 2024 19:40
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions and tidyings :)

www/docs/mp/index.php Show resolved Hide resolved
www/includes/easyparliament/templates/html/mp/register.php Outdated Show resolved Hide resolved
www/includes/easyparliament/templates/html/mp/register.php Outdated Show resolved Hide resolved
www/includes/easyparliament/templates/html/mp/register.php Outdated Show resolved Hide resolved
@ajparsons ajparsons requested a review from dracos June 5, 2024 13:35
@ajparsons ajparsons merged commit 3bda49a into master Jun 5, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants