Bug #33142654 THE SECOND HEAP-USE-AFTER-FREE ISSUE OF MYSQL SERVER

As part of optimizer trace in the range optimizer, we try to print a
view definition, and this may access uninitialized data.

This patch
    Bug#21929967 GCOLS: GCOL VALUE CHANGES WHEN SESSION CHANGES SQL_MODE
introduced QT_NO_TABLE for printing identifiers.

The fix is to test the QT_NO_TABLE flag before accessing table_name.

Change-Id: I976cc2464e289851972c1151a122573f6f45f5ea

Author: Tor Didriksen

sql/item.cc

@@ -2881,7 +2881,7 @@ void Item_ident::print(const THD *thd, String *str, enum_query_type query_type,
     return;
   }
 
-  if (db_name_arg && db_name_arg[0] && !(query_type & QT_NO_DB) &&
+  if (!(query_type & QT_NO_DB) && db_name_arg && db_name_arg[0] &&
       !alias_name_used()) {
     const size_t d_name_len = strlen(d_name);
     if (!((query_type & QT_NO_DEFAULT_DB) &&
@@ -2890,7 +2890,7 @@ void Item_ident::print(const THD *thd, String *str, enum_query_type query_type,
       str->append('.');
     }
   }
-  if (table_name_arg[0] && !(query_type & QT_NO_TABLE)) {
+  if (!(query_type & QT_NO_TABLE) && table_name_arg[0]) {
     append_identifier(thd, str, t_name, strlen(t_name));
     str->append('.');
   }