Skip to content

Commit 2ff216c

Browse files
author
Tor Didriksen
committed
Bug#34991760 query_rewrite_plugins.logging_general_raw test crashes with FORTIFY_SOURCE=3
A digest in the query rewrite plugin is always 32 bytes long. Fix bad arguments to snprintf. Change-Id: Ib46855206384fb4c23b3850502ad0c19e612c831 (cherry picked from commit bcf84d9cc1963b255eb04ff1a3741e40ea055f77)
1 parent 4c8b502 commit 2ff216c

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

plugin/rewriter/services.cc

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,9 @@ using std::string;
3939
namespace services {
4040

4141
string print_digest(const unsigned char *digest) {
42-
const size_t string_size = PARSER_SERVICE_DIGEST_LENGTH * 2;
43-
char digest_str[string_size + sizeof('\0')];
42+
char digest_str[2 * PARSER_SERVICE_DIGEST_LENGTH + 1];
4443
for (int i = 0; i < PARSER_SERVICE_DIGEST_LENGTH; ++i)
45-
snprintf(digest_str + i * 2, string_size, "%02x", digest[i]);
44+
sprintf(digest_str + i * 2, "%02x", digest[i]);
4645
return digest_str;
4746
}
4847

0 commit comments

Comments
 (0)