Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include missing headers breaking VS2019 version 16.6 nightly builds #291

Closed
wants to merge 2 commits into from
Closed

Include missing headers breaking VS2019 version 16.6 nightly builds #291

wants to merge 2 commits into from

Conversation

BillyONeal
Copy link

@BillyONeal BillyONeal commented Feb 7, 2020

Include the right headers in kdf_sha_crypt.cc:

  • <stddef.h> for size_t
  • <cstdlib> for std::strtol
  • <tuple> for std::tie (this is the one that broke the build)
  • <iterator> for std::distance

Include the right headers in kdf_pbkdf2.cc:

  • <stdint.h> for uint8_t
  • <cstdlib> for std::strotl
  • <tuple> for std::tie (this is the one that broke the build)
  • <iterator> for std::distance

Include the right headers in http_auth_method_basic.cc:

  • <iterator> for std::back_inserter (this is the one that broke the build)
  • <system_error> for std::make_error_code and std::errc

Failing output was:

F:\gitP\mysql\mysql-server\router\src\http\src\kdf_sha_crypt.cc(71): error C2039: 'tie': is not a member of 'std' [F:\gitP\mysql\mysql-server\build_amd64\router\src\http\src\http_auth_backend_lib.vcxproj]
F:\gitP\mysql\mysql-server\router\src\http\src\kdf_sha_crypt.cc(71): error C3861: 'tie': identifier not found [F:\gitP\mysql\mysql-server\build_amd64\router\src\http\src\http_auth_backend_lib.vcxproj]
F:\gitP\mysql\mysql-server\router\src\http\src\kdf_pbkdf2.cc(79): error C2039: 'tie': is not a member of 'std' [F:\gitP\mysql\mysql-server\build_amd64\router\src\http\src\http_auth_backend_lib.vcxproj]
F:\gitP\mysql\mysql-server\router\src\http\src\kdf_pbkdf2.cc(79): error C3861: 'tie': identifier not found [F:\gitP\mysql\mysql-server\build_amd64\router\src\http\src\http_auth_backend_lib.vcxproj]

Include the right headers in kdf_sha_crypt.cc:
* <stddef.h> for size_t
* <cstdlib> for std::strtol
* <tuple> for std::tie            (this is the one that broke the build)
* <iterator> for std::distance

Include the right headers in kdf_pbkdf2.cc:
* <stdint.h> for uint8_t
* <cstdlib> for std::strotl
* <tuple> for std::tie            (this is the one that broke the build)
* <iterator> for std::distance

F:\gitP\mysql\mysql-server\router\src\http\src\kdf_sha_crypt.cc(71): error C2039: 'tie': is not a member of 'std' [F:\gitP\mysql\mysql-server\build_amd64\router\src\http\src\http_auth_backend_lib.vcxproj]
F:\gitP\mysql\mysql-server\router\src\http\src\kdf_sha_crypt.cc(71): error C3861: 'tie': identifier not found [F:\gitP\mysql\mysql-server\build_amd64\router\src\http\src\http_auth_backend_lib.vcxproj]
F:\gitP\mysql\mysql-server\router\src\http\src\kdf_pbkdf2.cc(79): error C2039: 'tie': is not a member of 'std' [F:\gitP\mysql\mysql-server\build_amd64\router\src\http\src\http_auth_backend_lib.vcxproj]
F:\gitP\mysql\mysql-server\router\src\http\src\kdf_pbkdf2.cc(79): error C3861: 'tie': identifier not found [F:\gitP\mysql\mysql-server\build_amd64\router\src\http\src\http_auth_backend_lib.vcxproj]
@BillyONeal
Copy link
Author

This was exposed in MySQL by microsoft/STL#482

@mysql-oca-bot
Copy link

Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at http://www.oracle.com/technetwork/community/oca-486395.html
Please make sure to include your MySQL bug system user (email) in the returned form.
Thanks

@BillyONeal
Copy link
Author

Hello @mysql-oca-bot ! I'm contributing this as "Microsoft Corporation", and it looks like we already signed according to the page to which you linked.

* <iterator> for std::back_inserter.
* <system_error> for std::make_error_code and std::errc.
@mysql-admin
Copy link

@BillyONeal :Sorry for the delay in response. Please see direct email reply

Thanks
==Omer

@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment:
"I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it."
Thanks

@BillyONeal
Copy link
Author

I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

@BillyONeal
Copy link
Author

Specifically, being contributed by "Microsoft Corporation" which has signed the OCA. My work email address is bion at microsoft dot com; I created a MySQL bug tracker account with that address.

@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow
bug http://bugs.mysql.com/bug.php?id=98880 for updates.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants