-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include missing headers breaking VS2019 version 16.6 nightly builds #291
Conversation
Include the right headers in kdf_sha_crypt.cc: * <stddef.h> for size_t * <cstdlib> for std::strtol * <tuple> for std::tie (this is the one that broke the build) * <iterator> for std::distance Include the right headers in kdf_pbkdf2.cc: * <stdint.h> for uint8_t * <cstdlib> for std::strotl * <tuple> for std::tie (this is the one that broke the build) * <iterator> for std::distance F:\gitP\mysql\mysql-server\router\src\http\src\kdf_sha_crypt.cc(71): error C2039: 'tie': is not a member of 'std' [F:\gitP\mysql\mysql-server\build_amd64\router\src\http\src\http_auth_backend_lib.vcxproj] F:\gitP\mysql\mysql-server\router\src\http\src\kdf_sha_crypt.cc(71): error C3861: 'tie': identifier not found [F:\gitP\mysql\mysql-server\build_amd64\router\src\http\src\http_auth_backend_lib.vcxproj] F:\gitP\mysql\mysql-server\router\src\http\src\kdf_pbkdf2.cc(79): error C2039: 'tie': is not a member of 'std' [F:\gitP\mysql\mysql-server\build_amd64\router\src\http\src\http_auth_backend_lib.vcxproj] F:\gitP\mysql\mysql-server\router\src\http\src\kdf_pbkdf2.cc(79): error C3861: 'tie': identifier not found [F:\gitP\mysql\mysql-server\build_amd64\router\src\http\src\http_auth_backend_lib.vcxproj]
This was exposed in MySQL by microsoft/STL#482 |
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at http://www.oracle.com/technetwork/community/oca-486395.html |
Hello @mysql-oca-bot ! I'm contributing this as "Microsoft Corporation", and it looks like we already signed according to the page to which you linked. |
* <iterator> for std::back_inserter. * <system_error> for std::make_error_code and std::errc.
@BillyONeal :Sorry for the delay in response. Please see direct email reply Thanks |
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
Specifically, being contributed by "Microsoft Corporation" which has signed the OCA. My work email address is bion at microsoft dot com; I created a MySQL bug tracker account with that address. |
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
Include the right headers in kdf_sha_crypt.cc:
<stddef.h>
forsize_t
<cstdlib>
forstd::strtol
<tuple>
forstd::tie
(this is the one that broke the build)<iterator>
forstd::distance
Include the right headers in kdf_pbkdf2.cc:
<stdint.h>
foruint8_t
<cstdlib>
forstd::strotl
<tuple>
forstd::tie
(this is the one that broke the build)<iterator>
forstd::distance
Include the right headers in http_auth_method_basic.cc:
<iterator>
forstd::back_inserter
(this is the one that broke the build)<system_error>
forstd::make_error_code
andstd::errc
Failing output was: