-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEP0096] DeprecationWarning #2003
Comments
This module doesn't yet officially support Node.js 10, but if yourself or someone wants to volunteer to make the necessary changes, definitely welcome and the best way to move forward 👍 |
Unless someone knows another way, it's not really fixable in Node.js 10.0. The PR in Node.js nodejs/node#20298 is rolling and so we'll then have a non-deprecated API to use hopefully in some future 10.x release. |
Node.js 10.1 came out but not with the API we need, so we're still waiting for a Node.js release. |
To update this: the needed API has been merged into Node.js 10.x branch now, and so it will be available with Node.js 10.2 I presume. The code still needs to be changed in this module to use the new APIs. I'm going to take a look, but if anyone is inclined to do so, you're also welcome to open a pull request with Node.js 10.x compat 👍 |
@florenthagard not sure if github would have sent a notice so I'll comment here, I've created a PR that addresses nodejs 10 compatibility. semver I also fixed the error on |
I facing the same issue.. Please tell me, when can I expect this to be updated?? |
Same issue here, I'm wondering why the issue was closed. |
The PR was merged, which closed related issues automatically. I was mainly hoping someone would test it out. Would you be willing to test the fix to validate before release? Install instructions in the last section of https://github.com/mysqljs/mysql#install |
@dougwilson run npm console install mysqljs / mysql and correct the problem |
Still In Node v10.6.0 (node:25325) [DEP0095] DeprecationWarning: timers.enroll() is deprecated. Please use setTimeout instead. |
What version of this module are you using? |
v2.15.0 |
So 2.15.0 was published before Node.js 10 existed, let alone when this was fixed :) You just need to install the current version of this module to get the Node.js 10 support 👍 |
Working mysql@2.16.0 |
I have updated to node v10.8.0 and mysql version 2.16.0 and i am still getting this warning. any thoughts? |
Open a new issue with full code and steps to reproduce. |
[DEP0096] DeprecationWarning: timers.unenroll() is deprecated. Please use clearTimeout instead.
on mysql/lib/protocol/Protocol.js: Timers.unenroll(sequence);
NodeJS 10
The text was updated successfully, but these errors were encountered: