Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Stale connections that have not been used for idletimeout. #1749

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

aankur
Copy link

@aankur aankur commented Jun 6, 2017

#962 Add ability to remove connections from the pool which have been stale for idletimeout period in milliseconds

@4ver
Copy link

4ver commented Jun 20, 2017

Might be a good idea to change the following shift to pop to prevent the pool from cycling through the connections keeping em all alive.

https://github.com/mysqljs/mysql/blob/master/lib/Pool.js#L37

@dougwilson dougwilson force-pushed the master branch 2 times, most recently from 638d79d to 88bade0 Compare June 29, 2017 18:13
@adriancooney
Copy link

Any more movement on this? Our instances are hogging connections for too long and it'd be great to be able to close out those idle connections.

@akleiber
Copy link

duplicate of #2218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants