Fixes #59. Bug/restoring self #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invoking `to_s` on the given value returns a TString (since it's a potentially-in-language method). This value was not being unwrapped when printing the message, meaning the output for errors would almost always look like "no variable or method for <Myst::TString#...>:List", which is confusing and not helpful.
When an exception is raised in the language, all of the normal logic for managing the self stack is bypassed, meaning that raising an error could/would leave the self stack in an incorrect state. This commit adds logic to restore the self stack whenever an exception is rescued to what it was upon visiting the ExceptionHandler node.
Similar to rescuing from a `raise`, `break` similarly bypasses the normal logic for managing `self`, so it must be manually added.
faultyserver
force-pushed
the
bug/restoring_self
branch
from
3281852
to
c80f548
Compare
This was referenced Dec 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a number of cases where the flow of control through the interpreter bypasses the normal logic for managing the
self_stack. Namely, this was an issue withraiseandbreak, where the implementation uses Crystal exceptions to panic up the callstack.The solution was to manually save the state of
self_stackbefore entering anExceptionHandlerorInvocation, then manually restore it when these flow control expressions are encountered.See #59 for a slightly more in-depth description of the issue.