-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing small details on dev setup script #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few fix-ups:
chmod +x setup.sh
- Change
poetry run install
topoetry install
- Add
set -euo pipefail
to enable 'bash strict mode', which will stop script execution if any one command fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lil' fix left.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! Thanks.
* now we good bruh * smol changes to script * poetry run pytest so no need to activate env * permissions * added empty line back to readme
* deployment of pipeline schemas * Refactor schemes for future metrics changes (#74) * Refactor schemes for future metrics changes * Update version * Add schemas for hardware related metrics (#75) * Add schemas for hardware metrics * Add project_id to metrics * add a few tests for pipeline cloud (#72) * add a few tests for pipeline cloud and have to cleanup too many flake8 errs * Refactor schemes for future metrics changes (#74) * Refactor schemes for future metrics changes * Update version * Add schemas for hardware related metrics (#75) * Add schemas for hardware metrics * Add project_id to metrics * Refactor schemes for future metrics changes (#74) * Refactor schemes for future metrics changes * Update version * Add schemas for hardware related metrics (#75) * Add schemas for hardware metrics * Add project_id to metrics * add a few tests for pipeline cloud and have to cleanup too many flake8 errs Co-authored-by: andrei-trandafir <47391556+andrei-trandafir@users.noreply.github.com> * add same checks made pre-commit to CI workflow (#76) * add same checks made pre-commit to CI workflow * wrongly sorted file was alredy in codebase * just checking how to set path * rename old job to lint again * adding flake8 error to see job catch it * removed flake8 error * fixing small details on dev setup script (#73) * now we good bruh * smol changes to script * poetry run pytest so no need to activate env * permissions * added empty line back to readme * add compute type field to run create schema (#77) * add compute type field to run create schema * pydantic enum serialization fix * move rsc type to runGet schema * add comment * v bump * Add created_at and updated_at fields to Token schema. Towards NA-247. * Add expires_at to TokenCreate. Towards NA-247. * Bump version to 0.0.27. * Schema change * Deployment schemas update * Class name change * Deployment schema change * Update to schema * Additional schema fields in deployment * Additional schema fields in deployment * import order reformat * Version bump * RM PipelineGet Project * Import cleanup * VB Co-authored-by: andrei-trandafir <47391556+andrei-trandafir@users.noreply.github.com> Co-authored-by: Max Schulkin <maxemijo@gmail.com> Co-authored-by: Alex Pearce <alex@mystic.ai>
No description provided.