Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a few tests for pipeline cloud #72

Merged
merged 7 commits into from
Apr 11, 2022
Merged

add a few tests for pipeline cloud #72

merged 7 commits into from
Apr 11, 2022

Conversation

bjornaer
Copy link
Contributor

and as a side effect of some commits without linting/format checks I had to cleanup some flake8 errors

@bjornaer bjornaer self-assigned this Mar 31, 2022
@bjornaer bjornaer requested a review from a team as a code owner March 31, 2022 14:11
@bjornaer bjornaer requested review from alexpearce and paulcjh March 31, 2022 14:11
andrei-trandafir and others added 6 commits April 6, 2022 14:37
* Refactor schemes for future metrics changes

* Update version
* Add schemas for hardware metrics

* Add project_id to metrics
* Refactor schemes for future metrics changes

* Update version
* Add schemas for hardware metrics

* Add project_id to metrics
Copy link
Contributor

@alexpearce alexpearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always nice to have a few more tests! Thanks a lot for this, and for the lining fix-ups. I guess we're not running those in the CI then?

@bjornaer bjornaer merged commit b7de643 into main Apr 11, 2022
@bjornaer bjornaer deleted the max/add-cloud-tests branch April 11, 2022 10:17
paulcjh pushed a commit that referenced this pull request Apr 19, 2022
* add a few tests for pipeline cloud and have to cleanup too many flake8 errs

* Refactor schemes for future metrics changes (#74)

* Refactor schemes for future metrics changes

* Update version

* Add schemas for hardware related metrics (#75)

* Add schemas for hardware metrics

* Add project_id to metrics

* Refactor schemes for future metrics changes (#74)

* Refactor schemes for future metrics changes

* Update version

* Add schemas for hardware related metrics (#75)

* Add schemas for hardware metrics

* Add project_id to metrics

* add a few tests for pipeline cloud and have to cleanup too many flake8 errs

Co-authored-by: andrei-trandafir <47391556+andrei-trandafir@users.noreply.github.com>
paulcjh added a commit that referenced this pull request Apr 25, 2022
* deployment of pipeline schemas

* Refactor schemes for future metrics changes (#74)

* Refactor schemes for future metrics changes

* Update version

* Add schemas for hardware related metrics (#75)

* Add schemas for hardware metrics

* Add project_id to metrics

* add a few tests for pipeline cloud (#72)

* add a few tests for pipeline cloud and have to cleanup too many flake8 errs

* Refactor schemes for future metrics changes (#74)

* Refactor schemes for future metrics changes

* Update version

* Add schemas for hardware related metrics (#75)

* Add schemas for hardware metrics

* Add project_id to metrics

* Refactor schemes for future metrics changes (#74)

* Refactor schemes for future metrics changes

* Update version

* Add schemas for hardware related metrics (#75)

* Add schemas for hardware metrics

* Add project_id to metrics

* add a few tests for pipeline cloud and have to cleanup too many flake8 errs

Co-authored-by: andrei-trandafir <47391556+andrei-trandafir@users.noreply.github.com>

* add same checks made pre-commit to CI workflow (#76)

* add same checks made pre-commit to CI workflow

* wrongly sorted file was alredy in codebase

* just checking how to set path

* rename old job to lint again

* adding flake8 error to see job catch it

* removed flake8 error

* fixing small details on dev setup script (#73)

* now we good bruh

* smol changes to script

* poetry run pytest so no need to activate env

* permissions

* added empty line back to readme

* add compute type field to run create schema (#77)

* add compute type field to run create schema

* pydantic enum serialization fix

* move rsc type to runGet schema

* add comment

* v bump

* Add created_at and updated_at fields to Token schema.

Towards NA-247.

* Add expires_at to TokenCreate.

Towards NA-247.

* Bump version to 0.0.27.

* Schema change

* Deployment schemas update

* Class name change

* Deployment schema change

* Update to schema

* Additional schema fields in deployment

* Additional schema fields in deployment

* import order reformat

* Version bump

* RM PipelineGet Project

* Import cleanup

* VB

Co-authored-by: andrei-trandafir <47391556+andrei-trandafir@users.noreply.github.com>
Co-authored-by: Max Schulkin <maxemijo@gmail.com>
Co-authored-by: Alex Pearce <alex@mystic.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants