Deployment schemas (NA-513) #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor schemes for future metrics changes * Update version
* Add schemas for hardware metrics * Add project_id to metrics
* add a few tests for pipeline cloud and have to cleanup too many flake8 errs * Refactor schemes for future metrics changes (#74) * Refactor schemes for future metrics changes * Update version * Add schemas for hardware related metrics (#75) * Add schemas for hardware metrics * Add project_id to metrics * Refactor schemes for future metrics changes (#74) * Refactor schemes for future metrics changes * Update version * Add schemas for hardware related metrics (#75) * Add schemas for hardware metrics * Add project_id to metrics * add a few tests for pipeline cloud and have to cleanup too many flake8 errs Co-authored-by: andrei-trandafir <47391556+andrei-trandafir@users.noreply.github.com>
* add same checks made pre-commit to CI workflow * wrongly sorted file was alredy in codebase * just checking how to set path * rename old job to lint again * adding flake8 error to see job catch it * removed flake8 error
* now we good bruh * smol changes to script * poetry run pytest so no need to activate env * permissions * added empty line back to readme
* add compute type field to run create schema * pydantic enum serialization fix * move rsc type to runGet schema * add comment * v bump
Towards NA-247.
Towards NA-247.
alexpearce
reviewed
Apr 25, 2022
alexpearce
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR are relevant to NA-513, NA-521/522/523/524.
There are 3 schema changes, specifically:
DeploymentGet,DeploymentCreate&DeploymentPatch.