Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show warning screen immediately after rating site #16

Closed
sorgoz opened this issue Mar 3, 2012 · 4 comments
Closed

Don't show warning screen immediately after rating site #16

sorgoz opened this issue Mar 3, 2012 · 4 comments

Comments

@sorgoz
Copy link

sorgoz commented Mar 3, 2012

It annoys me everytime.

Is it made intentionally?

@samitolvanen
Copy link
Contributor

Yes, it updates the warning screen immediately after you rate the site. The warning is shown if you rate the site poorly and hidden if you rate the site good. Probably the logic necessary to avoid showing the warning immediately after rating wouldn't be worth it. We definitely do want to immediately hide the warning in case of a good rating.

@sorgoz
Copy link
Author

sorgoz commented Mar 3, 2012

So,

  1. If site is rated poorly by WOT, but is rated good by user - hide warning.
  2. If site is rated good/unknown, but user rate it to red - ? (currently we show warning, I suggest to don't show it immediately)

@samitolvanen
Copy link
Contributor

I feel it complicates the warning logic, but it can obviously be done. Would it work if we just set the warned flag in cache for sites after the user rates a site?

wot.cache.setflags(target, { warned: true });

Warnings are not shown for sites that have the warned flag set in the cache.

@sorgoz
Copy link
Author

sorgoz commented Mar 4, 2012

done (for chrome only). I'll file this issue to other browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants