Add support third-party library to serialize url params #121
+51
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfou
force-pushed
the
custom-encode-params-method
branch
3 times, most recently
from
b20ca21
to
6893d40
Compare
|
@mzabriskie so do you think it's a better solution than #101? I think so 😸 |
|
@mzabriskie are you still busy? Is the PR could be merged or should I a custom version on my project? 😿 |
davidfou
force-pushed
the
custom-encode-params-method
branch
from
6893d40
to
14ede9e
Compare
|
Sorry! Yes, I like this better too. Thanks for the help! |
mzabriskie
added a commit
that referenced
this pull request
Oct 27, 2015
Add support third-party library to serialize url params
|
You're welcome 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because servers don't parse url params the same way, an optional third-party could be use. To do so,
paramsSerializercan be provided in the configuration. It's a function which takesparamsas arguments and returns encodingparams.This pull request is related to #101.