Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload disqus when invoking componentDidUpdate #9

Merged
merged 1 commit into from
Oct 15, 2015

Conversation

arunoda
Copy link
Contributor

@arunoda arunoda commented Aug 2, 2015

Sometimes when browsing though a set of article, (like using a sidebar) our component get updated.
So, we need to show a different comment box. But it does not do it.

Here's the fix.

Review on Reviewable

Sometimes when browsing though a set of article, (like using a sidebar) our component get updated.
So, we need to show a different comment box. But it does not do it.

Here's the fix.
@mzabriskie
Copy link
Owner

Why are you putting _disqusAdded on the window? Would be better to just add it to this.

@arunoda
Copy link
Contributor Author

arunoda commented Aug 2, 2015

But it's possible to destroy a component altogether before the loading
complete.
On 2015 අගෝ 2, ඉරිදා at ප.ව. 11.12 Matt Zabriskie notifications@github.com
wrote:

Why are you putting _disqusAdded on the window? Would be better to just
add it to this.


Reply to this email directly or view it on GitHub
#9 (comment)
.

@hiddentao
Copy link
Contributor

+1 I need this too. Thanks @arunoda .

mzabriskie added a commit that referenced this pull request Oct 15, 2015
Reload disqus when invoking `componentDidUpdate`
@mzabriskie mzabriskie merged commit 177b3ab into mzabriskie:master Oct 15, 2015
@arunoda
Copy link
Contributor Author

arunoda commented Oct 16, 2015

Awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants