Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding wheel distribution to deployment plan #2

Merged
merged 2 commits into from
Oct 14, 2020

Conversation

barrybarrette
Copy link

Hi @mzaglia ,

First off, thanks for maintaining this package. I found it really useful. However, the lack of a wheel was giving me some install problems with my work environment. Hopefully you agree there is value in distributing a wheel for ease of use for those of us with restricted environments.

@barrybarrette
Copy link
Author

I also noticed your tests package was being included with the distribution, and it was causing my unit tests in my project to fail. Unless you think these need to be included with the distributed package (as opposed to cloning the source from GitHub), I went ahead and filtered them out of the package list. Happy to discuss further with you if needed.

@mzaglia mzaglia merged commit dd5b75b into mzaglia:master Oct 14, 2020
@barrybarrette
Copy link
Author

Thanks @mzaglia for merging this in quickly. It looks like I missed the fact that your deploys only run on tagged commits. Would you like me to submit another PR with a proper tag or can you manually release this build to PyPi? Thanks again!

@mzaglia
Copy link
Owner

mzaglia commented Oct 14, 2020

I've just pushed a tag. Thanks for your collaboration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants