Add support for Ubee Router DVW32CB #17
Conversation
Adds support for Ubee Router model DVW32CB.
pyubee/__init__.py
Outdated
| r'<td>\d+</td>' # age | ||
| r'<td>.+</td>' # rssi | ||
| r'<td>.*</td>' # ip address | ||
| r'<td>(.+)?</td>' # hostname |
There was a problem hiding this comment.
I would suggest to use .* instead of .+ here.
I had issue with one phone connected to Ubee router, but not showing up in Home Assistant (pull request #15). It was because that phone didn't have hostname assigned in router's list of connected devices and regex didn't match.
There was a problem hiding this comment.
Done! How does it look now?
There was a problem hiding this comment.
I think you can remove the ? now; i.e., (.*) is enough.
There was a problem hiding this comment.
Removed it! Thanks for your help
|
Looks good to me, merged. @mzdrale can you do a release and do a pull request for home assistant? |
|
Would I get credit for the addition on Home Assistant? I've been wanting to make a contribution and see my handle in the changelogs for a while :) |
|
You probably would... go for it! :)
|
|
@seanvictory Thank you for contributing! You will get credit for contributing to |
|
Version 0.9 released (GitHub, PyPI). |
|
@mzdrale Thank you! I'll make the pull request soon, and comment back here once it's been created :) |
|
Made the pull request! 🎉 |
|
Link to pull request: home-assistant/core#32406 |
|
Good work @seanvictory :) New Home Assistant 0.107 released and you are mentioned as contributor. :) (search for your username) |
Adds support for Ubee Router model DVW32CB.