Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete: own properties first #45

Closed
slavaGanzin opened this issue Sep 27, 2015 · 3 comments
Closed

Autocomplete: own properties first #45

slavaGanzin opened this issue Sep 27, 2015 · 3 comments
Labels

Comments

@slavaGanzin
Copy link

Hello again, I want to implement this feature:
When you ask kernel for suggestion, it show's own properties of prototype first and only after all generic one's like toString, etc.
Maybe just move lower Object properties.

This is frustrating when you didn't remember name of "do that stuff" in module having only that one function and running through all this generics.

@n-riesco
Copy link
Owner

The current order is:

  1. Property names of the object
  2. Property names of the [prototype] chain
  3. Javascript keywords

If I understand correctly the order you are asking for is:

  1. Property names of the [prototype] chain
  2. Property names of the object
  3. Javascript keywords

Is this what you mean?

@slavaGanzin
Copy link
Author

Now first ones are global properties started with double underscore like:
_define, _lookup
After that own properties of object (they should be first).
And after that object Object properties.

@n-riesco
Copy link
Owner

Oh! This is my bad. I added a .sort() at the wrong place. I will fix it.

@n-riesco n-riesco added the bug label Sep 28, 2015
n-riesco added a commit that referenced this issue Oct 2, 2015
* Updated IJavascript and the tests to use the latest NEL package,
  v0.1.x.

Closes #44
Fixes #45
n-riesco added a commit to n-riesco/jp-babel that referenced this issue Oct 10, 2015
* Ensured completion matches are ordered: own property names followed by
  names in the [prototype] chain.

Fixes n-riesco/ijavascript#45
n-riesco added a commit to n-riesco/jp-coffeescript that referenced this issue Oct 10, 2015
* Ensured completion matches are ordered: own property names followed by
  names in the [prototype] chain.

Fixes n-riesco/ijavascript#45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants