-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable await in expressions #11
Conversation
a18e265
to
039723c
Compare
The implementation is copied from Node's --experimental-repl-await Signed-off-by: Vadim Markovtsev <vadim@sourced.tech>
|
+1 on this. Hope to see this merged, and mine closed. |
@vmarkovtsev @alancnet Sorry for the silence. I've had a quick read, but I haven't had a chance to test this PR. I've just had an idea while thinking about this PR: I'd like to test if it's possible to replace this PR with a PR that adds the flag |
@n-riesco I've already tried that but it did not work for me. The reason is that this flag works only in the REPL mode. |
ping |
@vmarkovtsev apologies for the silence. I'll work on this tomorrow. |
* Adapted from n-riesco/nel#11 by Vadim Markovtsev (@vmarkovtsev).
@vmarkovtsev I've moved this PR to a branch of the IJavascript repository. For the time being, I'm distributing this branch in the package ijavascript-await (I did something similar with jmp and jmp-prebuilt when we were testing the transition from zmq to the prebuilt binaries of zeromq). I'm also distributing Ideally, I'd like this functionality to be part of @vmarkovtsev I'd like to give you credit for your contribution here. Please, would you have a look at the branch I created in the IJavascript repository? And if you're happy, please would create a PR against that branch to update the file AUTHORS with your details? |
@n-riesco Sure, as long as it works I am fine π n-riesco/ijavascript#172 |
* kernel: Enable await in global expressions (thanks to Vadim Markovtsev. See n-riesco/nel#11 . Closes n-riesco/nel#11 Closes n-riesco/nel#10
@vmarkovtsev Your tests are passing π! For anyone wanting to test IJavascript with global await expressions, please, note that for the time being I'm distributing this feature in the package
|
Thanks! |
The implementation is copied from Node's
--experimental-repl-await
Screenshot of
ijavascript
with this patch:DISCLAIMER: I am a totally lame JS programmer π€¦ββοΈ: I have to spend some time to figure out how to write tests for this project, how to properly integrate acorn - it is currently integrated the same way as in Node, etc. So consider this a PoC. Feel free to implement everything by yourself and close this PR (I mean, really) or bear with me to make a proper PR. In the latter case I will be grateful for your JS improvement hints and lessons π