fix: actually allow to disable DERP #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frando
force-pushed
the
fix-set-derp-mode
branch
from
45c227f
to
fda31b4
Compare
Frando
force-pushed
the
fix-set-derp-mode
branch
from
a02a137
to
8b2a97e
Compare
flub
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
node::Builder::disable_derpis broken. We do not callMagicEndpointBuilder::disable_derpfor that, and at some point we changed the magic endpoint to default to the default, n0-supplied derp servers.This fixes this through a
DerpModeenum that is much more explicit I think.Fixes #1558
Notes & open questions
Change checklist