Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iroh can't be built from dependencies packaged with cargo vendor #1931

Closed
cameronfyfe opened this issue Jan 6, 2024 · 0 comments · Fixed by #1932
Closed

iroh can't be built from dependencies packaged with cargo vendor #1931

cameronfyfe opened this issue Jan 6, 2024 · 0 comments · Fixed by #1932

Comments

@cameronfyfe
Copy link
Contributor

cameronfyfe commented Jan 6, 2024 •
edited
Loading

build fails when building from a vendored tarball because the watchable crate v1.1.1 has a missing file when it's packaged with cargo vendor.

See NixOS/nixpkgs#276099 (comment)
@cameronfyfe cameronfyfe mentioned this issue Jan 6, 2024
Merged
3 tasks
@flub flub closed this as completed in #1932 Jan 8, 2024
flub added a commit that referenced this issue Jan 8, 2024
@cameronfyfe @flub
fix: build successfully from cargo vendor tarball (#1932)
2337cb2 
## Description

closes #1931 

Fixes the broken build when building from the vendored tarball produced
by `cargo vendor`. The problem was with a config in `watchable v1.1.1`
and was fixed in `watchable v1.1.2`
(https://github.com/khonsulabs/watchable/releases/tag/v1.1.2).

## Notes & open questions

## Change checklist


Co-authored-by: Floris Bruynooghe <flub@n0.computer>
fubuloubu pushed a commit to ApeWorX/iroh that referenced this issue Feb 21, 2024
@cameronfyfe @flub @fubuloubu
fix: build successfully from cargo vendor tarball (n0-computer#1932)
6eac7f2 
## Description

closes n0-computer#1931 

Fixes the broken build when building from the vendored tarball produced
by `cargo vendor`. The problem was with a config in `watchable v1.1.1`
and was fixed in `watchable v1.1.2`
(https://github.com/khonsulabs/watchable/releases/tag/v1.1.2).

## Notes & open questions

## Change checklist


Co-authored-by: Floris Bruynooghe <flub@n0.computer>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
iroh
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: build successfully from cargo vendor tarball cameronfyfe/iroh
1 participant
@cameronfyfe