Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build successfully from cargo vendor tarball #1932

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

cameronfyfe
Copy link
Contributor

Description

closes #1931

Fixes the broken build when building from the vendored tarball produced by cargo vendor. The problem was with a config in watchable v1.1.1 and was fixed in watchable v1.1.2 (https://github.com/khonsulabs/watchable/releases/tag/v1.1.2).

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.

@cameronfyfe cameronfyfe mentioned this pull request Jan 6, 2024
13 tasks
@flub flub enabled auto-merge (squash) January 8, 2024 11:23
@flub
Copy link
Contributor

flub commented Jan 8, 2024

thanks for caring!

@flub flub merged commit 2337cb2 into n0-computer:main Jan 8, 2024
26 of 27 checks passed
fubuloubu pushed a commit to ApeWorX/iroh that referenced this pull request Feb 21, 2024
## Description

closes n0-computer#1931 

Fixes the broken build when building from the vendored tarball produced
by `cargo vendor`. The problem was with a config in `watchable v1.1.1`
and was fixed in `watchable v1.1.2`
(https://github.com/khonsulabs/watchable/releases/tag/v1.1.2).

## Notes & open questions

## Change checklist


Co-authored-by: Floris Bruynooghe <flub@n0.computer>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

iroh can't be built from dependencies packaged with cargo vendor
2 participants