iroh: 0.11 -> 0.12

[crimeminister]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[crimeminister]

An error compiling a dependency is currently blocking:

error: couldn't read /build/iroh-0.12.0-vendor.tar.gz/watchable/src/.crate-docs.md: No such file or directory (os error 2)
 --> /build/iroh-0.12.0-vendor.tar.gz/watchable/src/lib.rs:1:10
  |
1 | #![doc = include_str!(".crate-docs.md")]
  |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[cameronfyfe]

An error compiling a dependency is currently blocking:

error: couldn't read /build/iroh-0.12.0-vendor.tar.gz/watchable/src/.crate-docs.md: No such file or directory (os error 2)
 --> /build/iroh-0.12.0-vendor.tar.gz/watchable/src/lib.rs:1:10
  |
1 | #![doc = include_str!(".crate-docs.md")]
  |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

It looks like .crate-docs.md in this watchable crate used by v0.12.0 for some reason gets filtered out by the rustPlatform.fetchCargoTarball logic which calls cargo vendor (I ran cargo vendor manually for watchable and that .crate-docs.md file is missing in the resulting vendored folder). .crate-docs.md is in the published package for watchable though and since rustPlatform.importCargoLock doesn't use cargo vendor the build seems to work if you switch to that. It's also nice to switch to this so a hash for the dependencies doesn't need to be manually specified anymore. Putting working code in separate comment.

[cameronfyfe]

@crimeminister I forgot that you're not allowed to import from derivation so the lockFile = "${src}/Cargo.lock" I recommended is not allowed. You can remedy this by copying and commiting the whole Cargo.lock file here (this is what other people are doing) or you can wait until the root issue is fixed in the next version of iroh and go back to specifying cargoHash (I submitted this PR n0-computer/iroh#1932).

[crimeminister]

not allowed. You can remedy this by copying an

Thanks so much for your investigation @cameronfyfe. I'll include the Cargo.lock file for now, and track the progress of your PR with the plan of sending another update for the next version, assuming you don't get there first.

[cameronfyfe]

Works on my machine (x86-linux)

[crimeminister]

@cameronfyfe Is there another step to getting this PR reviewed and/or merged? Thanks.

[cameronfyfe]

@crimeminister Just need to wait for someone with commit rights to approve/merge it, I can only approve it. Sometimes takes a bit. If you want it soon you can try to find someone to request review from or post about it in a forum and hope someone sees it.

[crimeminister]

@crimeminister Just need to wait for someone with commit rights to approve/merge it, I can only approve it. Sometimes takes a bit. If you want it soon you can try to find someone to request review from or post about it in a forum and hope someone sees it.

Thanks @cameronfyfe. I am in no particular rush, I just wanted to make sure I wasn't missing a step in the process on my end.

[wegank]

Done in #299006.