fix(iroh-net): avoid double connections to relays #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `self.connect` call in `Actor::recv_detail` was racing to create a connection with an incoming actor message to do so. This simplifies `recv_detail` and only attempts to do so if there is already a connection, which is the correct logic in the first place.
ramfox
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
lgtm
This has a "fundamental" change, in that we now immediately dial when we build a relay::http::Client, but this is probably a good thing. The way our code is set up, any ActiveRelay that we create is only created when we are trying to either immediately send content, or establish a connection with our home relay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
self.connectcall inActor::recv_detailwas racing to create a connection with an incoming actor message to do so.This simplifies
recv_detailand only attempts to do so if there is already a connection, which is the correct logic in the first place.Closes #2144