ref: Clean up public API regarding bound/local/listening addresses #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This primarily renames .available_addresses() to .listen_addresses() and .listen_addr() to .local_address(). this makes .local_address() consistent with e.g. quinn's API and avoids the confusion between available on the machine vs uses by the provider.
flub
commented
Mar 28, 2023
| @@ -147,7 +149,7 @@ const fn is_unicast_link_local(addr: Ipv6Addr) -> bool { | |||
| } | |||
|
|
|||
| /// Given a listen/bind address, finds all the local addresses for that address family. | |||
| pub fn find_local_addresses(listen_addr: SocketAddr) -> Vec<SocketAddr> { | |||
| pub(crate) fn find_local_addresses(listen_addr: SocketAddr) -> Result<Vec<SocketAddr>> { | |||
There was a problem hiding this comment.
I don't think this should be pub, and probably should even be in the provider module. Though that would make the diff harder to read.
dignifiedquire
approved these changes
Mar 29, 2023
|
/netsim |
|
|
|
/netsim |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This primarily renames .available_addresses() to
.listen_addresses() and .listen_addr() to .local_address(). this
makes .local_address() consistent with e.g. quinn's API and avoids the
confusion between available on the machine vs uses by the provider.