fix: ignore empty frames #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes false errors being logged
|
why do empty messages arrive at all? |
I don't know. It comes from hyper is nothing you can do anything about. I have seen it frequently as the last message before a connection gets cleanly closed. Not sure if it can also happen in between valid messages. But a rpc message will never be 0 size since even zero size messages will at least contain the type id, so it is safe to ignore them. Serialization will also fail if the result is 0 bytes. Found some other http2 impls having issues with / producing extra empty data frames. |
|
We have merged the big PR that solves this as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes false errors being logged