Support transform request properly on upload #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice. |
|
Okay, I'm checking it |
|
Alright, now will be properly transformed on upload 👌 And I don't see anything on upload, maybe is from your local dev env? My cookies list are empty. |
DreamlandOwO
changed the title
|
Check the demo, it its not there too maybe its from one of my chrome extension, I don't know. I'll check it later. |
|
Yea I still don't see it.. maybe
|
|
found the reason. nvm :) |
|
merged the code, and I figured from your ss that the backend of the demo was legacy code :) updated the demo as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just realize we can set request body by call
uppy.setMeta(), so I grab the request body come out fromrequester.transformRequestParams()and stick it in, now is properly transformed before upload.But unfortunately I don't think we can transform request method or query params, that just doesn't seems possible (or may be too expensive?). If I try set method or endpoint in XHR plugin config, nothing will happen after calleduppy.upload()instead of actually starting sending files to the server. I haven't try swap XHR plugin before upload, that's kinda dumb tho.Nvm I literally found my way to do that part. Fixing right now.