Skip to content
This repository has been archived by the owner on Nov 10, 2017. It is now read-only.

Add gulpfile #10

Closed
wants to merge 9 commits into from
Closed

Add gulpfile #10

wants to merge 9 commits into from

Conversation

lionelB
Copy link
Contributor

@lionelB lionelB commented May 28, 2014

the gulp file provide

  • a localserver with livereload
  • transpile (no more JSXTransformer
  • a dist task wich uglify kept.js

@lionelB
Copy link
Contributor Author

lionelB commented May 28, 2014

Introducing a build tool complexifies a bit the install process since we rely on bower & npm
One option can be to remove bower and rely on npm (react / react-bootstrap and bootstrap are available on npm)

that way it could be something like

$ npm install gulp -g 

and install dependencies

$ npm install

We could also support browserify to split kept app into small components and only add the react-bootstrap components that are used.

@n1k0
Copy link
Owner

n1k0 commented May 28, 2014

Thanks a bunch for this. I'm all in for relying on npm only, and using browserify was in the pipe anyway. Maybe we should just add browserify support in a next PR though… Up to you :)

Dumb question, what's the purpose of calling npm run bower?

@lionelB
Copy link
Contributor Author

lionelB commented May 28, 2014

Dumb question, what's the purpose of calling npm run bower?

I'm afraid I've no smart answer. I will fix that soon

@lionelB
Copy link
Contributor Author

lionelB commented May 28, 2014

I've corrected the README
Ok to add browserify but as it involves refactoring the code, I preferred to wait for your review.

@n1k0
Copy link
Owner

n1k0 commented May 28, 2014

Ok to add browserify but as it involves refactoring the code, I preferred to wait for your review.

I'll probably take care of that one, but will happily ask you a review as I'm all new to that tool :)

@n1k0
Copy link
Owner

n1k0 commented May 28, 2014

I've corrected the README

Ah regarding the change, I'm still surprised to see further reference to Bower. I thought it was possible to entirely get rid of it so we could solely rely on npm. Am I mistaken?

@lionelB lionelB closed this May 28, 2014
@lionelB lionelB mentioned this pull request May 28, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants