-
Notifications
You must be signed in to change notification settings - Fork 9
Conform to ConfigInitializable
#9
base: master
Are you sure you want to change the base?
Conversation
Instead of injecting the concrete type `Droplet`, use `ClientFactoryProtoco` instead. This applied to; - GitHub client - Travis CI - SlackClient - Bob
Conform to `ConfigInitializable` protocol to allow of initialization with `Config` inline with Vapor documentation. Following conformance implementation were added, - Bob - TravisCI - GitHub
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR, thanks for your contribution 👍
Do you think it would make sense to move the config name "bob"
into a constant?
Hi @mosamer , many thanks for your PR 🎊 WDYT? |
Hi @vincentaudoire, thanks for the review. I understand your security concerns but I feel they are already addressed.
|
This PR adds support for initializing Bob, TravisCI and GitHub using Vapor configs. This allows an initialization process that is more inline with other Vapor projects and tutorials.