-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database errors #40
Comments
Try to set to lowercase for pichu. |
Making the Pichu ID lowercase does in fact get rid of the errors for that, but the "No amiibo part of game series" are still present. |
because no amiibo was with those ids are released so far. I will remove them for now. Edit: Do try again, thanks for testing it out. I had removed those gameseries that does not exist. I guess I oversight it |
Why were they in the JSON then? The tool validates the json by:
|
You can find the source for the scanner here if you're interested, it's written in C# for .NET Core https://github.com/DanTheMan827/AmiiboApiValidator Maybe it'd be worthwhile to configure it as a GitHub Action for testing to catch any errors before they'd get merged? |
I guess a long time ago I did some wrong checking on an old script that I run to generate most of the stuff. The whole thing was set up when I was still studying, that's why on the site it's stated that it was for education purpose only.
Never heard of GitHub Action, this is totally new to me. Thank you, I would look at it when I had the time. Edit: I will close the issue now. |
I created and ran a tool to validate all of the data in the json file and this is the output:
I'm not entirely sure if I'm just parsing the ID incorrectly, or if these truly are correct.
To get the series ID I take the first 12 bits of the character ID (up to 0xFFF)
Mind you, I'm not sure if the first 12 bits is correct... 3dbrew.org says only the first 10 bits (up to 0x3FF) are part of the series ID and the remaining 6 are the character ID (up to 0x3F)
The Pichu ID also wasn't corrected in the character list.
The text was updated successfully, but these errors were encountered: