Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database errors #40

Closed
DanTheMan827 opened this issue Jul 9, 2020 · 6 comments
Closed

Database errors #40

DanTheMan827 opened this issue Jul 9, 2020 · 6 comments
Assignees
Labels

Comments

@DanTheMan827
Copy link
Contributor

DanTheMan827 commented Jul 9, 2020

I created and ran a tool to validate all of the data in the json file and this is the output:

No amiibo part of game series: 0x194 - Pokemon
No amiibo part of game series: 0x198 - Pokemon
No amiibo part of game series: 0x19c - Pokemon
No amiibo part of game series: 0x1a0 - Pokemon
No amiibo part of game series: 0x1a4 - Pokemon
No amiibo part of game series: 0x1a8 - Pokemon
No amiibo part of game series: 0x1b0 - Pokemon
No amiibo part of game series: 0x1b4 - Pokemon
No amiibo part of game series: 0x1b8 - Pokemon
No amiibo part of game series: 0x1bc - Pokemon

No amiibo for character: 0x19AC - Pichu

Invalid amiibo character ID: 0x19AC - Pichu

I'm not entirely sure if I'm just parsing the ID incorrectly, or if these truly are correct.

To get the series ID I take the first 12 bits of the character ID (up to 0xFFF)

Mind you, I'm not sure if the first 12 bits is correct... 3dbrew.org says only the first 10 bits (up to 0x3FF) are part of the series ID and the remaining 6 are the character ID (up to 0x3F)

The Pichu ID also wasn't corrected in the character list.

@N3evin
Copy link
Owner

N3evin commented Jul 9, 2020

Try to set to lowercase for pichu.

@DanTheMan827
Copy link
Contributor Author

Making the Pichu ID lowercase does in fact get rid of the errors for that, but the "No amiibo part of game series" are still present.

@N3evin
Copy link
Owner

N3evin commented Jul 9, 2020

Making the Pichu ID lowercase does in fact get rid of the errors for that, but the "No amiibo part of game series" are still present.

because no amiibo was with those ids are released so far. I will remove them for now.

Edit: Do try again, thanks for testing it out. I had removed those gameseries that does not exist. I guess I oversight it
Commit: 7f91e4d

@N3evin N3evin self-assigned this Jul 9, 2020
@N3evin N3evin added the bug label Jul 9, 2020
@DanTheMan827
Copy link
Contributor Author

Why were they in the JSON then?

The tool validates the json by:

  • Ensuring all keys are lowercase and match the length requirements
  • Checks for missing images
  • Checks for missing game series
  • Checks for missing amiibo series
  • Checks to make sure at least one amiibo is part of a game series ID
  • Checks to make sure at least one amiibo is part of an amiibo series ID
  • Checks to make sure that at least one amiibo is part of a character ID

@DanTheMan827
Copy link
Contributor Author

You can find the source for the scanner here if you're interested, it's written in C# for .NET Core

https://github.com/DanTheMan827/AmiiboApiValidator

Maybe it'd be worthwhile to configure it as a GitHub Action for testing to catch any errors before they'd get merged?

@N3evin
Copy link
Owner

N3evin commented Jul 9, 2020

Why were they in the JSON then?

The tool validates the json by:

  • Ensuring all keys are lowercase and match the length requirements
  • Checks for missing images
  • Checks for missing game series
  • Checks for missing amiibo series
  • Checks to make sure at least one amiibo is part of a game series ID
  • Checks to make sure at least one amiibo is part of an amiibo series ID
  • Checks to make sure that at least one amiibo is part of a character ID

I guess a long time ago I did some wrong checking on an old script that I run to generate most of the stuff. The whole thing was set up when I was still studying, that's why on the site it's stated that it was for education purpose only.

You can find the source for the scanner here if you're interested, it's written in C# for .NET Core

https://github.com/DanTheMan827/AmiiboApiValidator

Maybe it'd be worthwhile to configure it as a GitHub Action for testing to catch any errors before they'd get merged?

Never heard of GitHub Action, this is totally new to me. Thank you, I would look at it when I had the time.

Edit: I will close the issue now.

@N3evin N3evin closed this as completed Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants