Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the fetch step in the GitHub Action #9

Merged
merged 2 commits into from
May 21, 2023
Merged

Refactor the fetch step in the GitHub Action #9

merged 2 commits into from
May 21, 2023

Conversation

jonathanio
Copy link
Contributor

Refactor the fetch step in the GitHub Action to make use of github.action_repository and github.action_ref contexts to allow dynamic fetching of the artifacts based on the passed version, which will remove the need to automatically update both the action and the documentation.

Also, remove the redundant GitHub Workflow Jobs which used to update both action.yaml and README.md during drafts and releases as well.

Checklist

Please confirm the following checks:

  • My pull request follows the guidelines set out in CONTRIBUTING.md.
  • I have performed a self-review of my code and run any tests locally to check.
  • I have added tests that prove my changes are effective and work correctly.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my code and corrected any misspellings.
  • Each commit in this pull request has a meaningful subject & body for context.
  • I have squashed all "fix(up)" commits to provide a clean code history.
  • My pull request has an appropriate title and description for context.
  • I have linked this pull request to other issues or pull requests as needed.
  • I have added type/..., changes/..., and 'release/...' labels as needed.

@jonathanio
Refactor the fetch step in the GitHub Action
92efd08 
Refactor the fetch step in the GitHub Action to make use of
github.action_repository and github.action_ref contexts to allow dynamic
fetching of the artifacts based on the passed version, which will remove
the need to automatically update both the action and the documentation.
@jonathanio
Remove the redundant GitHub Workflow Jobs
e89d859 
Remove the redundant GitHub Workflow Jobs which used to update both
action.yaml and README.md during drafts and releases now that the GitHub
Action uses dynamic information to launch itself.
@jonathanio jonathanio added priority/high This is a high-priority issue or pull reqest release/fix A fix for a bug or identified issue with this pull request type/bug Something is not working correctly update/documentation Update with improvements to the documentation update/github-action Update with changes to the GitHub Action update/scripts Update with changes to scripts labels May 21, 2023
@jonathanio jonathanio self-assigned this May 21, 2023
@jonathanio jonathanio requested a review from a team as a code owner May 21, 2023 22:51
@jonathanio jonathanio merged commit 57d31a5 into main May 21, 2023
@jonathanio jonathanio deleted the refactor-action-fetching branch May 21, 2023 22:54
@jonathanio jonathanio added release/update An update to an existing feature is made with this pull request type/refactoring A refactoring of existing code and removed type/bug Something is not working correctly labels May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jonathanio jonathanio

Labels
priority/high This is a high-priority issue or pull reqest release/fix A fix for a bug or identified issue with this pull request release/update An update to an existing feature is made with this pull request type/refactoring A refactoring of existing code update/documentation Update with improvements to the documentation update/github-action Update with changes to the GitHub Action update/scripts Update with changes to scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonathanio