Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On a K4, when a preprogrammed message contains > (RIT clear), program crashes #585

Closed
ny4i opened this issue Mar 4, 2022 · 7 comments · Fixed by #586 or #587
Closed

On a K4, when a preprogrammed message contains > (RIT clear), program crashes #585

ny4i opened this issue Mar 4, 2022 · 7 comments · Fixed by #586 or #587
Assignees
Labels
Milestone

Comments

@ny4i
Copy link
Collaborator

ny4i commented Mar 4, 2022

No description provided.

@ny4i ny4i added the bug label Mar 4, 2022
@ny4i ny4i self-assigned this Mar 4, 2022
@n4af
Copy link
Owner

n4af commented Mar 4, 2022

i wonder:
a) whether he meant on k4
b) whether also applies to xit clear:
procedure TK4Radio.RITClear(whichVFO: TVFO);
begin
Self.SendToRadio(whichVFO,'RC','');
end;

procedure TK4Radio.XITClear(whichVFO: TVFO);
begin
Self.SendToRadio(whichVFO,'RC','');
end;

@ny4i
Copy link
Collaborator Author

ny4i commented Mar 4, 2022 via email

@ny4i
Copy link
Collaborator Author

ny4i commented Mar 4, 2022

My mistake. According to the book, RC; clears both RIT and XIT. No way to clear just one.

@n4af
Copy link
Owner

n4af commented Mar 4, 2022

testing on K3, seems to work FB.

@ny4i
Copy link
Collaborator Author

ny4i commented Mar 4, 2022 via email

@ny4i
Copy link
Collaborator Author

ny4i commented Mar 5, 2022

The code in RITClear received an Abstract run time exception. The code was calling the TNetRadio object incorrectly (earlier implementation model).

@ny4i ny4i added this to the 2022-04 milestone Mar 5, 2022
@n4af n4af closed this as completed in #586 Mar 5, 2022
@ny4i
Copy link
Collaborator Author

ny4i commented Mar 10, 2022

Reopening as the send CW is very choppy when sending to the network

@ny4i ny4i reopened this Mar 10, 2022
ny4i added a commit that referenced this issue Mar 10, 2022
A common theme was to short-circuit the specific function routine like SendCW to just send the message to the Networked radio. SendCW had important code that needed to be run even in the network case. So I added network code to AddToOutputBuffer. This fixed the CW. Closes #585
@n4af n4af closed this as completed in #587 Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants