Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Small transparent chin below the titlebar if window is shaded #1

Closed
Schlaefer opened this issue Nov 10, 2019 · 12 comments
Closed

Small transparent chin below the titlebar if window is shaded #1

Schlaefer opened this issue Nov 10, 2019 · 12 comments
Assignees
Labels
bug Something isn't working

Comments

@Schlaefer
Copy link

Every shaded windows shows a little chin below the titlebar:

Screenshot_20191110_155338

on 3651b35
KDE Plasma Version: 5.17.2
KDE Frameworks Version: 5.63.0
Qt Version: 5.13.1
Kernel Version: 5.3.8

@n4n0GH
Copy link
Owner

n4n0GH commented Nov 10, 2019

Confirmed. I actually already had that listed in the source code as an issue, forgot to open one here. Thanks.

@n4n0GH n4n0GH self-assigned this Nov 10, 2019
@n4n0GH
Copy link
Owner

n4n0GH commented Nov 11, 2019

Note to self: render error changes size when titlebar uses different height settings.

shadow_error

@n4n0GH n4n0GH transferred this issue from n4n0GH/breezeway-mod Nov 14, 2019
@n4n0GH n4n0GH added the bug Something isn't working label Nov 16, 2019
@n4n0GH
Copy link
Owner

n4n0GH commented Nov 27, 2019

This glitch only occurs if shadow sizes "Large" and "Very Large" are used. Now I know when it happens, let's fix this shit!

@arun54321
Copy link
Contributor

arun54321 commented Nov 28, 2019

I getting that bug even with medium sized shadows.

@n4n0GH
Copy link
Owner

n4n0GH commented Nov 28, 2019

What other settings are you using?

@arun54321
Copy link
Contributor

https://allthepics.net/images/Screenshot_20191129_120840.jpg

shadow: medium, strength 86%, color - black. no custom rule for dolphin

@n4n0GH
Copy link
Owner

n4n0GH commented Nov 29, 2019

Interesting. The screenshot size is also your screen's resolution?

@arun54321
Copy link
Contributor

Interesting. The screenshot size is also your screen's resolution?

No. It's a cropped screenshot. The screen resolution is 1920x1080.

@arun54321
Copy link
Contributor

The latest update fixed the bottom chin like bug but it introduced an artifact.
image

@n4n0GH
Copy link
Owner

n4n0GH commented Nov 29, 2019

Yes I pushed a work in progress. Consider the repo bleeding edge, only the releases are stable.

@n4n0GH
Copy link
Owner

n4n0GH commented Jan 4, 2020

So finally got around to work on this piece of shiet. The glitch is now gone, however a shadow will appear a bit offset to the bottom. This is however a much better look than what we had before so @arun54321 if you want you can pull the repo and recompile the theme to get much better looking shaded windows now. I'm working on fixing the offset tonight.

@arun54321
Copy link
Contributor

Looks good to me.

@n4n0GH n4n0GH closed this as completed Jan 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants