Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown file support in knowledge form #38

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

hyzx86
Copy link
Contributor

@hyzx86 hyzx86 commented Apr 16, 2024

No description provided.

@n4ze3m n4ze3m self-requested a review April 16, 2024 12:19
@n4ze3m
Copy link
Owner

n4ze3m commented Apr 16, 2024

Amazing! Do you have any other changes to push?

@hyzx86
Copy link
Contributor Author

hyzx86 commented Apr 16, 2024

Amazing! Do you have any other changes to push?

Not yet. I'm just trying to familiarize myself with the tool 😅

Copy link
Owner

@n4ze3m n4ze3m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will merge it into the next branch since it needs a markdown loader configured. Is that okay?

@hyzx86
Copy link
Contributor Author

hyzx86 commented Apr 16, 2024

LGTM. I will merge it into the next branch since it needs a markdown loader configured. Is that okay?

Well, I'm learning the big model of localization deployment for the first time.
I thought markdown file was treated in the same way as txt file format.😅

@n4ze3m
Copy link
Owner

n4ze3m commented Apr 16, 2024

I thought markdown file was treated in the same way as txt file format.😅

:) Yes, you are correct. Sorry about it.

@n4ze3m n4ze3m merged commit d479283 into n4ze3m:next Apr 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants