CMake support and small fixes #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no guarantee that file descriptor for m172am/log_input is set before starting ReadThread. It should be started after M172AM.Open() and LogInput.Open().
|
Sorry, I don't have the means, resources or time to support any BSD-based OS. If you want, I can provide a link to your program in my README for those that are interested, just please don't call it mvoice. I am going to close all three of your BSD-related PRs. Once you have decided on a new name for your derivation you can send me the url to your repo. |
This was referenced Sep 29, 2024
|
I respect your intention. |
|
If it were me, I would remove the fork dependency and use a name not containing "mvoice", but if you want it, it's okay by me. |
|
"yamvoice", your mvoice with portability fork is now at https://github.com/jg1uaa/yamvoice . No need to provide link to this project in your README.md. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CMake support for easily build on Non-Linux environment
I want to build mvoice on OpenBSD.
add
#include <libintl.h>to AboutDlg.hThis is mandatory to use gettext().
add
exp10f()to codec2/defines.hexp10f() is Linux-specific, and M17Client's Daemon/codec2/defines.h has exp10f() code (now mvoice's codec2/defines.h is same as M17Client's one.)