Skip to content

Commit

Permalink
refactor(core): Remove inferral of execution status
Browse files Browse the repository at this point in the history
Execution status is non-nullable since #9483 and we have been tracking missing edge cases for a month since #9476 and had zero Sentry reports, so it's time to finally remove inferral.

https://n8nio.slack.com/archives/C069HS026UF/p1718267902737659
  • Loading branch information
ivov committed Jun 21, 2024
1 parent 553b135 commit 04de23c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 26 deletions.
8 changes: 0 additions & 8 deletions packages/cli/src/executions/execution.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import type {
ExecutionStatus,
} from 'n8n-workflow';
import {
ErrorReporterProxy as EventReporter,
ApplicationError,
ExecutionStatusList,
Workflow,
Expand All @@ -27,7 +26,6 @@ import { NodeTypes } from '@/NodeTypes';
import { Queue } from '@/Queue';
import type { ExecutionRequest, ExecutionSummaries } from './execution.types';
import { WorkflowRunner } from '@/WorkflowRunner';
import { getStatusUsingPreviousExecutionStatusMethod } from './executionHelpers';
import type { IGetExecutionsQueryFilter } from '@db/repositories/execution.repository';
import { ExecutionRepository } from '@db/repositories/execution.repository';
import { WorkflowRepository } from '@db/repositories/workflow.repository';
Expand Down Expand Up @@ -111,12 +109,6 @@ export class ExecutionService {
return undefined;
}

if (!execution.status) {
const { data, workflowData, ...rest } = execution;
EventReporter.info('Detected `null` execution status', { extra: { execution: rest } });
execution.status = getStatusUsingPreviousExecutionStatusMethod(execution);
}

return execution;
}

Expand Down
18 changes: 0 additions & 18 deletions packages/cli/src/executions/executionHelpers.ts

This file was deleted.

0 comments on commit 04de23c

Please sign in to comment.