-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for unit testing using vitest in editor-ui #4184
feat: add support for unit testing using vitest in editor-ui #4184
Conversation
@@ -10,11 +10,8 @@ | |||
"importHelpers": true, | |||
"allowSyntheticDefaultImports": true, | |||
"baseUrl": ".", | |||
"typeRoots": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these even needed anymore?
I'm able to remove typeRoots
and types
, and still able to build and test everything in this package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you please update the package-lock.json once more? and remove type
& typesRoot
from editor-ui
?
@netroy I've updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Got released with |
…4184) * feat: add support for unit testing using vitest in editor-ui * fix(editor): update tsconfig types and typeRoots * chore(editor): update package-lock.json
No description provided.