perf(tooling): Upgrade to TypeScript 4.8 #4207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
netroy
reviewed
Sep 28, 2022
netroy
reviewed
Sep 28, 2022
| @@ -23,9 +23,9 @@ export class PushoverApi implements ICredentialType { | |||
| requestOptions: IHttpRequestOptions, | |||
| ): Promise<IHttpRequestOptions> { | |||
| if (requestOptions.method === 'GET') { | |||
| Object.assign(requestOptions.qs, { token: credentials.apiKey }); | |||
| Object.assign(requestOptions.qs ?? {}, { token: credentials.apiKey }); | |||
There was a problem hiding this comment.
we really need to revisit our usage of Object.assign. it's seems to be used unnecessarily and incorrectly in many places. This should either be
requestOptions.qs = Object.assign(requestOptions.qs ?? {}, { token: credentials.apiKey })
or
requestOptions.qs = requestOptions.qs ?? {}
Object.assign(requestOptions.qs, { token: credentials.apiKey })
There was a problem hiding this comment.
Moved to use a nullish check instead of ?? {}, to remain closer to current behavior. Object.assign(undefined, obj) throws so we know the target is defined in these calls. Dug deeper and it looks like root cause is Object.assign overloads now constraining the target param to be a subset of {}.
netroy
approved these changes
Oct 5, 2022
|
Got released with |
valya
pushed a commit
to valya/n8n
that referenced
this pull request
Nov 8, 2022
* ⬆️ Upgrade to TypeScript 4.8 * 🔥 Remove unneeded setting * 📦 Update `package-lock.json` * ⏪ Restore `skipLibCheck` * 📦 Re-update `package-lock.json` * ♻️ Apply feedback * ♻️ Add check to new WhatsApp node * 📦 Update `package-lock.json` * Update package-lock.json * ran `npm run lintfix` Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.