Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor-ui): fix axios baseUrl when hosted under a subfolder #4336

Merged
merged 4 commits into from
Oct 13, 2022

Conversation

netroy
Copy link
Member

@netroy netroy commented Oct 13, 2022

Issue reported here

@linear
Copy link

linear bot commented Oct 13, 2022

N8N-5011

@netroy netroy requested a review from mutdmour October 13, 2022 13:14
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 13, 2022
mutdmour
mutdmour previously approved these changes Oct 13, 2022
packages/editor-ui/index.html Outdated Show resolved Hide resolved
@netroy netroy force-pushed the N8N-5011-fix-subfolder-hosting branch from 2f7659e to 976ced5 Compare October 13, 2022 14:17
@netroy netroy merged commit c2e9a03 into master Oct 13, 2022
@netroy netroy deleted the N8N-5011-fix-subfolder-hosting branch October 13, 2022 14:29
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
…io#4336)

* fix(editor-ui): fix axios baseUrl when hosted under a subfolder

* don't rewrite the favicon url twice

* setup a base href for all relative urls

* fix static urls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants