Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Switch from npm to pnpm #4429

Merged
merged 22 commits into from
Nov 9, 2022
Merged

feat: Switch from npm to pnpm #4429

merged 22 commits into from
Nov 9, 2022

Conversation

netroy
Copy link
Member

@netroy netroy commented Oct 24, 2022

No description provided.

@linear
Copy link

linear bot commented Oct 24, 2022

N8N-5200

@netroy netroy force-pushed the N8N-5200-switch-to-pnpm branch 2 times, most recently from 0874cf9 to 91198b1 Compare October 24, 2022 17:25
@netroy netroy changed the title feat: Switch from NPM to PNPM feat: switch from NPM to PNPM Oct 24, 2022
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 24, 2022
@netroy netroy changed the title feat: switch from NPM to PNPM feat: switch from npm to pnpm Oct 24, 2022
Copy link
Contributor

@cstuncsik cstuncsik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, we got here! Thanks for taking the effort! I left some comments and would be happy if someone else would also have a look.

packages/@n8n_io/eslint-config/frontend.js Show resolved Hide resolved
packages/@n8n_io/eslint-config/package.json Outdated Show resolved Hide resolved
packages/cli/package.json Outdated Show resolved Hide resolved
packages/design-system/package.json Outdated Show resolved Hide resolved
packages/design-system/package.json Outdated Show resolved Hide resolved
cstuncsik
cstuncsik previously approved these changes Oct 26, 2022
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via pnpm: start, build, dev, clean, lint, lintfix, format

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@netroy netroy requested a review from ivov November 4, 2022 22:44
@netroy netroy changed the title feat: switch from npm to pnpm feat: Switch from npm to pnpm Nov 4, 2022
@netroy netroy requested a review from cstuncsik November 9, 2022 16:20
@netroy netroy merged commit 7367773 into master Nov 9, 2022
@netroy netroy deleted the N8N-5200-switch-to-pnpm branch November 9, 2022 16:32
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Nov 9, 2022
@janober
Copy link
Member

janober commented Nov 10, 2022

Got released with n8n@0.202.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Nov 10, 2022
@borisbsu
Copy link

pnpm author is agains Open Intenet principals and blocks access to developers from multiple countries:
pnpm/pnpm#4800
pnpm/pnpm#5626
pnpm/pnpm#4498

I've spent an hour to find out a real reason why n8n can not be installed on my local machine. And cause of problem was in pnpm package manager. At the end I enabled VPN to overcome the problem.

IMHO - the Internet should be Opened for all individuals whenever from his residence, region and personaliy. So I recommend to not use pnpm package manager in n8n and switch to other well working alternatives like yarn or bit.

@netroy
Copy link
Member Author

netroy commented Jan 12, 2023

@borisbsu You don't need pnpm to install n8n. pnpm is only needed for our development setup. We tried yarn first, as many of us have prior experience with yarn, but yarn doesn't have an equivalent of --omit-dev since version 2.x, which leads to us having to ship dev dependencies in our docker builds.

However we do agree with you that the Internet should be open to app, and that's why the we provide multiple ways to install n8n, none of which require the end-user to even know what pnpm is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants