-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Lazy load nodes for credentials testing #4760
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
Enhancement outside /nodes-base and /editor-ui
n8n team
Authored by the n8n team
node/improvement
New feature or request
ui
Enhancement in /editor-ui or /design-system
labels
Nov 29, 2022
Joffcom
previously approved these changes
Nov 29, 2022
netroy
changed the title
fix: Lazy load nodes for credentials testing
fix: Lazy load nodes for credentials testing N8N-5776
Nov 29, 2022
netroy
changed the title
fix: Lazy load nodes for credentials testing N8N-5776
fix: Lazy load nodes for credentials testing
Nov 29, 2022
netroy
force-pushed
the
fix-credentials-testing
branch
2 times, most recently
from
November 29, 2022 15:00
cb54739
to
a25cd6f
Compare
netroy
force-pushed
the
fix-credentials-testing
branch
from
November 29, 2022 17:30
f24f2c2
to
c4d0790
Compare
Joffcom
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good.
n8n-assistant
bot
added
the
Upcoming Release
Will be part of the upcoming release
label
Nov 30, 2022
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
core
Enhancement outside /nodes-base and /editor-ui
n8n team
Authored by the n8n team
node/improvement
New feature or request
ui
Enhancement in /editor-ui or /design-system
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixed the issue of the frontend not passing in
nodeToTestWith
to the backend