Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Credential overwrites should take precedence over credential default values #4782

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

netroy
Copy link
Member

@netroy netroy commented Dec 1, 2022

currently if we have a non-falsey value in a credential defaults, overwrites don't apply for that field. So the overwrites are working only for null, undefined, and ''.

fixes #4781

@netroy netroy requested a review from krynble December 1, 2022 12:05
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Dec 1, 2022
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@netroy netroy merged commit 2ce6291 into master Dec 2, 2022
@netroy netroy deleted the N8N-5807-fix-cred-overwrites branch December 2, 2022 08:46
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Dec 2, 2022
@janober
Copy link
Member

janober commented Dec 2, 2022

Got released with n8n@0.205.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Dec 2, 2022
MiloradFilipovic added a commit that referenced this pull request Dec 2, 2022
* master:
  📚 Update CHANGELOG.md and main package.json to 0.205.0
  🔖 Release n8n@0.205.0
  ⬆️ Set n8n-core@0.145.0, n8n-editor-ui@0.171.0, n8n-nodes-base@0.203.0 and n8n-workflow@0.127.0 on n8n
  🔖 Release n8n-editor-ui@0.171.0
  ⬆️ Set n8n-design-system@0.45.0 and n8n-workflow@0.127.0 on n8n-editor-ui
  🔖 Release n8n-design-system@0.45.0
  🔖 Release n8n-nodes-base@0.203.0
  ⬆️ Set n8n-core@0.145.0 and n8n-workflow@0.127.0 on n8n-nodes-base
  🔖 Release n8n-node-dev@0.84.0
  ⬆️ Set n8n-core@0.145.0 and n8n-workflow@0.127.0 on n8n-node-dev
  🔖 Release n8n-core@0.145.0
  ⬆️ Set n8n-workflow@0.127.0 on n8n-core
  🔖 Release n8n-workflow@0.127.0
  fix: Credential overwrites should take precedence over credential default values (#4782)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use overwritten Postgres credentials in Postgres Node
3 participants