feat(editor): Execution filter #5496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstuncsik
changed the title
n8n-assistant
bot
added
n8n team
cstuncsik
changed the title
cstuncsik
changed the title
…ilter # Conflicts: # packages/editor-ui/src/components/ExecutionsList.vue # packages/editor-ui/src/components/ExecutionsView/ExecutionsSidebar.vue
…ion-metadata # Conflicts: # packages/cli/src/databases/entities/ExecutionEntity.ts # packages/cli/src/databases/migrations/mysqldb/index.ts # packages/cli/src/databases/migrations/postgresdb/index.ts # packages/cli/src/databases/migrations/sqlite/index.ts # packages/cli/src/executions/executions.service.ts
…ilter # Conflicts: # packages/editor-ui/src/components/ExecutionsList.vue # packages/editor-ui/src/components/ExecutionsView/ExecutionsSidebar.vue
…ion-metadata # Conflicts: # packages/cli/src/databases/migrations/mysqldb/index.ts # packages/cli/src/databases/migrations/postgresdb/index.ts # packages/cli/src/databases/migrations/sqlite/index.ts # packages/cli/src/executions/executions.service.ts
…ion-metadata # Conflicts: # packages/cli/src/databases/migrations/mysqldb/index.ts # packages/cli/src/databases/migrations/postgresdb/index.ts # packages/cli/src/databases/migrations/sqlite/index.ts
…ilter # Conflicts: # packages/editor-ui/src/components/ExecutionsList.vue
…ed in filter (#5739) * fix(editor): Suppress requesting current executions if metadata is used in filter * fix(editor): Fix arrows for select in popover
krynble
approved these changes
Mar 22, 2023
krynble
approved these changes
Mar 22, 2023
flipswitchingmonkey
approved these changes
Mar 22, 2023
|
Let me repeat my proposal from a few weeks ago: Migrations affecting the potentially gigantic executions_entity table are generally very problematic because of the sheer volume of that table. Therefore, we should consider splitting that table in two: In one we only store the execution data blob, in the other all the other (lightweight) columns. JOINing them when needed is still straightforward and future migrations should no longer be problematic. Thoughts? |
|
I like the idea @csuermann , this might greatly speed things up. |
n8n-assistant
bot
added
the
Upcoming Release
MiloradFilipovic
added a commit
that referenced
this pull request
Mar 24, 2023
* master: (80 commits) feat: Execution custom data saving and filtering (#5496) ci: Fix saml.api.test.ts (no-changelog) (#5764) docs: Refer to docker.n8n.io/n8nio/n8n for pulling n8n docker images (no-changelog) (#5763) 🚀 Release 0.221.0 (#5726) fix(core): Persist CurrentAuthenticationMethod setting change (#5762) feat(core): Limit user invites when SAML is enabled (#5761) fix(core): Setup nodeHelpers that aren't exposed in the code sandbox (no-changelog) (#5753) fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751) fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745) fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747) fix(editor): Use credentials when fetching node and credential types (#5760) fix: Update Posthog no-capture (#5693) fix(core): Return SAML service provider urls with config (#5759) fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751) feat(editor): Fix ResourceLocator dropdown style (#5714) feat(Filter Node): New node fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745) refactor(core): Stop importing LoggerProxy and createDeferredPromise in nodes-base (no-changelog) (#5742) feat(core): Make OAuth2 error handling consistent with success handling (#5555) fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747) ...
MiloradFilipovic
added a commit
that referenced
this pull request
Mar 30, 2023
…mapping-component * node-319-postgres-node-overhaul: (53 commits) ⚡ credentials test fix, clean up ⚡ singlton for conections feat: Execution custom data saving and filtering (#5496) Minor tweaks to query params decription. ⚡ ui update ⚡ error message update ⚡ clean up ⚡ ui fixes Copy updates. ⚡ hint to query ⚡ runQueries tests setup ⚡ select, update, upsert operations tests ⚡ executeQuery and insert operations tests ⚡ setup for testing operations, tests for deleteTable operation ⚡ refactoring ⚡ utils unit tests ⚡ config files clean up ⚡ unit tests wip ⚡ tests setup ⚡ improved error message ... # Conflicts: # packages/editor-ui/src/Interface.ts # packages/nodes-base/nodes/Postgres/Postgres.node.ts # packages/nodes-base/nodes/Postgres/v2/PostgresV2.node.ts # packages/nodes-base/nodes/Postgres/v2/actions/database/insert.operation.ts # packages/nodes-base/nodes/Postgres/v2/actions/database/update.operation.ts # packages/nodes-base/nodes/Postgres/v2/actions/database/upsert.operation.ts # packages/nodes-base/nodes/Postgres/v2/actions/router.ts # packages/nodes-base/nodes/Postgres/v2/actions/versionDescription.ts # packages/nodes-base/nodes/Postgres/v2/helpers/interfaces.ts # packages/nodes-base/nodes/Postgres/v2/methods/credentialTest.ts # packages/nodes-base/nodes/Postgres/v2/methods/index.ts # packages/nodes-base/nodes/Postgres/v2/methods/listSearch.ts # packages/nodes-base/nodes/Postgres/v2/methods/loadOptions.ts # packages/nodes-base/nodes/Postgres/v2/transport/index.ts
|
Got released with |
sunilrr
pushed a commit
to fl-g6/qp-n8n
that referenced
this pull request
Apr 24, 2023
* wip: workflow execution filtering * fix: import type failing to build * fix: remove console.logs * feat: execution metadata migrations * fix(editor): Move global executions filter to its own component * fix(editor): Using the same filter component in workflow level * fix(editor): a small housekeeping * checking workflowId in filter applied * fix(editor): update filter after resolving merge conflicts * fix(editor): unify empy filter status * feat(editor): add datetime picker to filter * feat(editor): add meta fields * fix: fix button override in datepicker panel * feat(editor): add filter metadata * feat(core): add 'startedBefore' execution filter prop * feat(core): add 'tags' execution query filter * Revert "feat(core): add 'tags' execution query filter" This reverts commit a7b9680. * feat(editor): add translations and tooltip and counting selected filter props * fix(editor): fix label layouts * fix(editor): update custom data docs link * fix(editor): update custom data tooltip position * fix(editor): update tooltip text * refactor: Ignore metadata if not enabled by license * fix(editor): Add paywall states to advanced execution filter * refactor: Save custom data also for worker mode * fix: Remove duplicate migration name from list * fix(editor): Reducing filter complexity and add debounce to text inputs * fix(editor): Remove unused import, add comment * fix(editor): simplify event listener * fix: Prevent error when there are running executions * test(editor): Add advanced execution filter basic unit test * test(editor): Add advanced execution filter state change unit test * fix: Small lint issue * feat: Add indices to speed up queries * feat: add customData limits * refactor: put metadata save in transaction * chore: remove unneed comment * test: add tests for execution metadata * fix(editor): Fixes after merge conflict * fix(editor): Remove unused import * wordings and ui fixes * fix(editor): type fixes * feat: add code node autocompletions for customData * fix: Prevent transaction issues and ambiguous ID in sql clauses * fix(editor): Suppress requesting current executions if metadata is used in filter (n8n-io#5739) * fix(editor): Suppress requesting current executions if metadata is used in filter * fix(editor): Fix arrows for select in popover * refactor: Improve performance by correcting database indices * fix: Lint issue * test: Fix broken test * fix: Broken test * test: add call data check for saveExecutionMetadata test --------- Co-authored-by: Valya Bullions <valya@n8n.io> Co-authored-by: Alex Grozav <alex@grozav.com> Co-authored-by: Omar Ajoue <krynble@gmail.com> Co-authored-by: Romain Minaud <romain.minaud@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PAY-149