Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix execution pruning queries #5562

Merged
merged 3 commits into from
Feb 24, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Feb 24, 2023

  1. Use OR operator when looking for executions based on age, and ids
  2. Delete executions in chunks to avoid sqlite error when there are over a 1000 executions to delete.
  3. Reduce the memory usage of the pruning operation significantly on larger databases

Fixes #5543 (comment)

@netroy netroy requested a review from ahsanv February 24, 2023 09:23
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Feb 24, 2023
@mzayn
Copy link

mzayn commented Feb 24, 2023

+1

@netroy netroy merged commit 88de661 into n8n-io:master Feb 24, 2023
@netroy netroy deleted the improve-execution-pruning branch February 24, 2023 17:02
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Feb 24, 2023
@netroy
Copy link
Member Author

netroy commented Feb 27, 2023

@madgbec can you please rephrase that question? I'm not sure what "card process" you are refering to.

netroy added a commit that referenced this pull request Feb 27, 2023
* fix(core): Execution pruning should delete query should use the `OR` operator

* fix(core): Prune executions in a chunk to avoid sqlite error "Expression tree is too large"

* reduce the memory usage during execution pruning
@janober
Copy link
Member

janober commented Feb 27, 2023

Got released with n8n@0.217.2

@janober janober removed the Upcoming Release Will be part of the upcoming release label Feb 27, 2023
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
* fix(core): Execution pruning should delete query should use the `OR` operator

* fix(core): Prune executions in a chunk to avoid sqlite error "Expression tree is too large"

* reduce the memory usage during execution pruning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Got Blank pages - And not appear login page
4 participants