Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url #5751

Merged
merged 1 commit into from Mar 22, 2023
Merged

fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url #5751

merged 1 commit into from Mar 22, 2023

Conversation

agobrech
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@agobrech agobrech changed the title fix(Http Request Node): Fix AWS credentials to automatically deconstruct the url fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url Mar 22, 2023
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Mar 22, 2023
@agobrech agobrech merged commit d30b892 into master Mar 22, 2023
21 of 22 checks passed
@agobrech agobrech deleted the node-418-bug-aws-predefined-credentials-not branch March 22, 2023 21:04
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 22, 2023
MiloradFilipovic added a commit that referenced this pull request Mar 23, 2023
@MiloradFilipovic
Merge branch 'feature/resource-mapping-component' into NODE-395-backe…
9570fd3 
…nd-foundations-sheets-node-api-endpoint

* feature/resource-mapping-component:
  fix(editor): Use credentials when fetching node and credential types (#5760)
  fix: Update Posthog no-capture (#5693)
  fix(core): Return SAML service provider urls with config (#5759)
  fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751)
  feat(editor): Fix ResourceLocator dropdown style (#5714)
  feat(Filter Node): New node
  fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745)
  refactor(core): Stop importing LoggerProxy and createDeferredPromise in nodes-base (no-changelog) (#5742)
  feat(core): Make OAuth2 error handling consistent with success handling (#5555)
  fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747)
  ci: Upgrade sanitize-html from 2.9.0 to 2.10.0 (#5744)
  fix(core): Remove circular refs from Code and push msg (#5741)
  fix(HTTP Request Node): Add streaming to binary response  (#5701)
  fix(core): Force-upgrade `http-cache-semantics` to address CVE-2022-25881 (#5733)
  fix(core): Force-upgrade `decode-uri-component` to address CVE-2022-38900 (#5734)
netroy pushed a commit that referenced this pull request Mar 23, 2023
@agobrech @netroy
fix(HTTP Request Node): Fix AWS credentials to automatically deconstr…
4ac944a 
…uct the url (#5751)

Workaround to use decompose uri whe OptionsUri is being used
MiloradFilipovic added a commit that referenced this pull request Mar 23, 2023
@MiloradFilipovic
Merge branch 'master' into feature/resource-mapping-component
8f3cb59 
* master:
  ci: Fix saml.api.test.ts (no-changelog) (#5764)
  docs: Refer to docker.n8n.io/n8nio/n8n for pulling n8n docker images (no-changelog) (#5763)
  🚀 Release 0.221.0 (#5726)
  fix(core): Persist CurrentAuthenticationMethod setting change (#5762)
  feat(core): Limit user invites when SAML is enabled (#5761)
  fix(core): Setup nodeHelpers that aren't exposed in the code sandbox (no-changelog) (#5753)
  fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751)
  fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745)
  fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747)
MiloradFilipovic added a commit that referenced this pull request Mar 23, 2023
@MiloradFilipovic
Merge branch 'feature/resource-mapping-component' into node-396-postg…
e3d4ff5 
…res-node-resorce-mapper

* feature/resource-mapping-component:
  ci: Fix saml.api.test.ts (no-changelog) (#5764)
  docs: Refer to docker.n8n.io/n8nio/n8n for pulling n8n docker images (no-changelog) (#5763)
  🚀 Release 0.221.0 (#5726)
  fix(core): Persist CurrentAuthenticationMethod setting change (#5762)
  feat(core): Limit user invites when SAML is enabled (#5761)
  fix(core): Setup nodeHelpers that aren't exposed in the code sandbox (no-changelog) (#5753)
  fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751)
  fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745)
  fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747)
MiloradFilipovic added a commit that referenced this pull request Mar 24, 2023
@MiloradFilipovic
Merge branch 'master' into N8N-5677-refactor-workflows-store
c35c34a 
* master: (80 commits)
  feat: Execution custom data saving and filtering (#5496)
  ci: Fix saml.api.test.ts (no-changelog) (#5764)
  docs: Refer to docker.n8n.io/n8nio/n8n for pulling n8n docker images (no-changelog) (#5763)
  🚀 Release 0.221.0 (#5726)
  fix(core): Persist CurrentAuthenticationMethod setting change (#5762)
  feat(core): Limit user invites when SAML is enabled (#5761)
  fix(core): Setup nodeHelpers that aren't exposed in the code sandbox (no-changelog) (#5753)
  fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751)
  fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745)
  fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747)
  fix(editor): Use credentials when fetching node and credential types (#5760)
  fix: Update Posthog no-capture (#5693)
  fix(core): Return SAML service provider urls with config (#5759)
  fix(HTTP Request Node): Fix AWS credentials to automatically deconstruct the url (#5751)
  feat(editor): Fix ResourceLocator dropdown style (#5714)
  feat(Filter Node): New node
  fix(core): Require Auth on icons and nodes/credentials types static files (no-changelog) (#5745)
  refactor(core): Stop importing LoggerProxy and createDeferredPromise in nodes-base (no-changelog) (#5742)
  feat(core): Make OAuth2 error handling consistent with success handling (#5555)
  fix(Split In Batches Node): Roll back changes in v1 and create v2 (#5747)
  ...
@janober
Copy link
Member

janober commented Mar 26, 2023

Got released with n8n@0.221.2

@janober
Copy link
Member

janober commented Mar 26, 2023

Got released with n8n@0.221.2

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
@agobrech @sunilrr
fix(HTTP Request Node): Fix AWS credentials to automatically deconstr…
7bada26 
…uct the url (n8n-io#5751)

Workaround to use decompose uri whe OptionsUri is being used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edumaciel10 edumaciel10 edumaciel10 left review comments

@maspio maspio maspio approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released Upcoming Release Will be part of the upcoming release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@agobrech @janober @edumaciel10 @maspio