feat(core): Return OAuth2 error body if available #5794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #5794 +/- ##
=======================================
Coverage 27.39% 27.39%
=======================================
Files 2937 2937
Lines 180177 180177
Branches 19557 19557
=======================================
Hits 49362 49362
Misses 130082 130082
Partials 733 733
☔ View full report in Codecov by Sentry. |
netroy
force-pushed
the
return-oauth-error-body
branch
from
dac374f
to
0d9c554
Compare
netroy
approved these changes
May 15, 2023
netroy
approved these changes
May 16, 2023
MiloradFilipovic
added a commit
that referenced
this pull request
May 16, 2023
* master: (22 commits) fix: Remove workflow execution credential error message when instance owner (#6116) refactor(editor): Drop vue-typed-mixins (no-changelog) (#6257) feat(core): Return OAuth2 error body if available (#5794) fix: Add itemSize config to workflows view recycle scroller (no-changelog) (#6238) fix(editor): Fix close and cancel operations on useMessage (no-changelog) (#6260) feat(editor): Add cloud ExecutionsUsage and API blocking using licenses (#6159) refactor(editor): Turn showMessage mixin to composable (#6081) (#6244) feat(core): Add experimental proxy support to License-SDK (no-changelog) (#6253) feat(core): Reduce the number of events sent to Sentry (#6235) feat(editor): Drop support for legacy browsers that do not have native ESM support (#6239) refactor(editor): Add missing interface IUserListAction (no-changelog) (#6241) ci: Debug e2e pipeline (no-changelog) (#6240) Revert "refactor(editor): Turn showMessage mixin to composable" (#6243) feat(editor): Updating node reference pattern in expression editor (#6228) refactor(editor): Remove unused dependencies (no-changelog) (#6223) refactor(editor): Turn showMessage mixin to composable (#6081) feat(editor): Version Control settings update (WIP) (#6233) ci: Fix linting issue on master (no-changelog) (#6232) fix: Prevent type error messages for manual executions (no-changelog) (#6229) fix(Code Node): Restore help text (#6231) ...
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We occasionally get reports of failed OAuth2 connection attempts. We usually display generic error messages, but these often don't tell the user what exactly is wrong.
As many APIs return more detailed information in the response body, we should provide this information where available.
For example, here is the error message currently returned when connecting to the bunq OAuth2 API:
Here is the same error after the change, now confirming what exactly is missing (and giving users a chance to fix the problem manually):
This is particularly useful for APIs that don't conform to the OAuth2 specification (and for which our library doesn't fully account).
Fixes:
#6256